Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization and Schem for release kit #133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4,016 changes: 4,016 additions & 0 deletions localisation/HCM Admin Console/v0.3/en_MZ/hcm-campaignmanager.json

Large diffs are not rendered by default.

83,642 changes: 83,642 additions & 0 deletions localisation/HCM Admin Console/v0.3/en_MZ/rainmaker-common.json

Large diffs are not rendered by default.

4,007 changes: 4,007 additions & 0 deletions localisation/HCM Admin Console/v0.3/fr_MZ/hcm-campaignmanager.json

Large diffs are not rendered by default.

Empty file.
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
[
{
"id": 2030,
"url": "/project-factory/v1/project-type/getProcessTrack",
"name": "Project Type progress track",
"enabled": true,
"leftIcon": "dynamic:ContractIcon",
"displayName": "Project Type progress track",
"orderNumber": -1,
"serviceCode": "project-factory"
},

{
"id": 2031,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add all the actions required

"url": "/health-project/v1/_search",
"name": "HEALTH PROJECT SEARCH",
"enabled": true,
"leftIcon": "dynamic:ContractIcon",
"displayName": "HEALTH PROJECT SEARCH",
"orderNumber": 0,
"serviceCode": "project"
},

{
"id": 2032,
"url": "/health-project/v1/_update",
"name": "Health Project Update",
"enabled": true,
"leftIcon": "dynamic:ContractIcon",
"displayName": "Health Project Update",
"orderNumber": 0,
"serviceCode": "project"
}
]
Comment on lines +1 to +34
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Standardize naming conventions and configuration

  1. Inconsistent naming conventions across services:

    • "Project Type progress track" (Title case)
    • "HEALTH PROJECT SEARCH" (Upper case)
    • "Health Project Update" (Title case)
  2. Inconsistent orderNumber values (-1 vs 0) without clear reasoning

Consider standardizing:

-  "name": "Project Type progress track",
+  "name": "PROJECT TYPE PROGRESS TRACK",
   ...
-  "orderNumber": -1,
+  "orderNumber": 0,

Committable suggestion skipped: line range outside the PR's diff.

Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
[
{
"rolecode": "CAMPAIGN_MANAGER",
"actionid": 2030,
"actioncode": "",
"tenantid": "mz"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

microplan integrator, boundary admin related role actions are mising

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

role master

{
"rolecode": "CAMPAIGN_MANAGER",
"actionid": 2031,
"actioncode": "",
"tenantid": "mz"
},
{
"rolecode": "CAMPAIGN_MANAGER",
"actionid": 2032,
"actioncode": "",
"tenantid": "mz"
}
]
Loading