-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization and Schem for release kit #133
base: master
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
[ | ||
{ | ||
"id": 2030, | ||
"url": "/project-factory/v1/project-type/getProcessTrack", | ||
"name": "Project Type progress track", | ||
"enabled": true, | ||
"leftIcon": "dynamic:ContractIcon", | ||
"displayName": "Project Type progress track", | ||
"orderNumber": -1, | ||
"serviceCode": "project-factory" | ||
}, | ||
|
||
{ | ||
"id": 2031, | ||
"url": "/health-project/v1/_search", | ||
"name": "HEALTH PROJECT SEARCH", | ||
"enabled": true, | ||
"leftIcon": "dynamic:ContractIcon", | ||
"displayName": "HEALTH PROJECT SEARCH", | ||
"orderNumber": 0, | ||
"serviceCode": "project" | ||
}, | ||
|
||
{ | ||
"id": 2032, | ||
"url": "/health-project/v1/_update", | ||
"name": "Health Project Update", | ||
"enabled": true, | ||
"leftIcon": "dynamic:ContractIcon", | ||
"displayName": "Health Project Update", | ||
"orderNumber": 0, | ||
"serviceCode": "project" | ||
} | ||
] | ||
Comment on lines
+1
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Standardize naming conventions and configuration
Consider standardizing: - "name": "Project Type progress track",
+ "name": "PROJECT TYPE PROGRESS TRACK",
...
- "orderNumber": -1,
+ "orderNumber": 0,
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
[ | ||
{ | ||
"rolecode": "CAMPAIGN_MANAGER", | ||
"actionid": 2030, | ||
"actioncode": "", | ||
"tenantid": "mz" | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. microplan integrator, boundary admin related role actions are mising There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. role master |
||
{ | ||
"rolecode": "CAMPAIGN_MANAGER", | ||
"actionid": 2031, | ||
"actioncode": "", | ||
"tenantid": "mz" | ||
}, | ||
{ | ||
"rolecode": "CAMPAIGN_MANAGER", | ||
"actionid": 2032, | ||
"actioncode": "", | ||
"tenantid": "mz" | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add all the actions required