Prod v2 #566
Prod v2 #566
Conversation
gurpreetsinghkhanna
requested review from
ramakrishnaippili-eGov,
elzanmathew-eGov and
poonam1512
as code owners
Update IFMS integration query
correct query for sw and ws locality search
Rollback ifms intigration query
[UM-4633]
[UM-6440]
Update IFMS integration
PropertyListReport search parameters
added where receiptnumber in IFMS
ifms integration
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
configs/egov-searcher/rainmaker-pt-gissearch.yml (1)
61-61: Clean Up: Trailing SpacesThere are multiple lines with trailing spaces. These should be removed to maintain code quality.
- select + select - additionalDetail->>'mobileNo' as mobileNp + additionalDetail->>'mobileNo' as mobileNp - from eg_tl_tradelicense tl + from eg_tl_tradelicense tl - + - ) as data + ) as data - from eg_tenant_config + from eg_tenant_config - $where + $where - + - + - + - select + select - surveyid, + surveyid, - operator: = + operator: =Also applies to: 66-66, 67-67, 75-75, 113-113, 129-129, 134-134, 140-140, 141-141, 153-153, 158-158, 159-159, 160-160, 175-175, 176-176, 210-210
Tools
yamllint
[error] 61-61: trailing spaces
(trailing-spaces)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- configs/egov-searcher/rainmaker-pt-gissearch.yml (1 hunks)
Additional context used
yamllint
configs/egov-searcher/rainmaker-pt-gissearch.yml
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
[error] 75-75: trailing spaces
(trailing-spaces)
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
[error] 158-158: trailing spaces
(trailing-spaces)
[error] 159-159: trailing spaces
(trailing-spaces)
[error] 160-160: trailing spaces
(trailing-spaces)
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 210-210: trailing spaces
(trailing-spaces)
Additional comments not posted (6)
configs/egov-searcher/rainmaker-pt-gissearch.yml (6)
12-21: Enhancement: Additional FieldsNew fields have been added to the
baseQuery, providing more detailed information in the search results. This is a useful enhancement.
33-48: Enhancement: Additional Search ParametersNew search parameters have been added, which enhance the search functionality by allowing more granular filtering.
57-79: New Feature: Trade License Applications SearchThe new search operation
searchTLApplicationsEODBprovides a way to fetch trade license applications with specific details. This is a valuable addition.Tools
yamllint
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
[error] 75-75: trailing spaces
(trailing-spaces)
82-134: New Feature: IFMS IntegrationThe new search operation
IFMSintegrationprovides a way to fetch payment details for integration with the IFMS system. This is a significant addition.Tools
yamllint
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
136-157: New Feature: Tenant Configuration SearchThe new search operation
GetTenantConfigprovides a way to fetch tenant configuration details. This is a useful addition.Tools
yamllint
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
161-214: New Feature: GIS Map SearchThe new search operation
searchGisMapprovides a way to fetch GIS map details. This is a valuable addition.Tools
yamllint
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 210-210: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
configs/egov-searcher/rainmaker-pt-gissearch.yml (1)
61-61: Remove trailing spaces.Trailing spaces found in multiple lines. Removing them will improve code quality.
- select - tl.applicationnumber, - tld.additionalDetail::text, - tl.status,additionalDetail->>'IPIN' as iPin, - additionalDetail->>'APPID' as appId, - additionalDetail->>'mobileNo' as mobileNp - from eg_tl_tradelicense tl - inner join eg_tl_tradelicensedetail tld on tld.tradelicenseid=tl.id and tld.additionalDetail->>'CHANNEL'='EODB' ) data - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Also applies to: 66-66, 67-67, 75-75, 113-113, 129-129, 134-134, 140-140, 141-141, 153-153, 158-160, 175-175, 176-176, 210-210 <details> <summary>Tools</summary> <details> <summary>yamllint</summary><blockquote> [error] 61-61: trailing spaces (trailing-spaces) </blockquote></details> </details> </blockquote></details> </blockquote></details> <details> <summary>Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** <details> <summary>Commits</summary> Files that changed from the base of the PR and between 655605c14132d9700ad049427b2192eedcb3dc11 and 4026cc132767d1ae3566a657c66d71d3a3377c01. </details> <details> <summary>Files selected for processing (1)</summary> * configs/egov-searcher/rainmaker-pt-gissearch.yml (1 hunks) </details> <details> <summary>Additional context used</summary> <details> <summary>yamllint</summary><blockquote> <details> <summary>configs/egov-searcher/rainmaker-pt-gissearch.yml</summary><blockquote> [error] 61-61: trailing spaces (trailing-spaces) --- [error] 66-66: trailing spaces (trailing-spaces) --- [error] 67-67: trailing spaces (trailing-spaces) --- [error] 75-75: trailing spaces (trailing-spaces) --- [error] 113-113: trailing spaces (trailing-spaces) --- [error] 129-129: trailing spaces (trailing-spaces) --- [error] 134-134: trailing spaces (trailing-spaces) --- [error] 140-140: trailing spaces (trailing-spaces) --- [error] 141-141: trailing spaces (trailing-spaces) --- [error] 153-153: trailing spaces (trailing-spaces) --- [error] 158-158: trailing spaces (trailing-spaces) --- [error] 159-159: trailing spaces (trailing-spaces) --- [error] 160-160: trailing spaces (trailing-spaces) --- [error] 175-175: trailing spaces (trailing-spaces) --- [error] 176-176: trailing spaces (trailing-spaces) --- [error] 210-210: trailing spaces (trailing-spaces) </blockquote></details> </blockquote></details> </details> <details> <summary>Additional comments not posted (15)</summary><blockquote> <details> <summary>configs/egov-searcher/rainmaker-pt-gissearch.yml (15)</summary><blockquote> `12-21`: **Ensure fields in baseQuery are necessary and correctly formatted.** The added fields in the `baseQuery` seem useful, but ensure they are required and correctly formatted. For example, make sure `concat(pt.propertyid , '/' , pt.surveyid) as primarykey` and `to_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdate` are necessary and correctly implemented. --- `22-27`: **Verify join conditions to avoid potential performance issues.** The join conditions have been modified to include additional tables. Ensure these joins are optimized and indexed properly to avoid performance degradation. --- `33-48`: **Review search parameters for consistency and necessity.** The search parameters have been modified and added. Ensure that the parameters like `pd.receiptdate` and `bn.blockname` are consistent with the search criteria and necessary for the query. --- `51-54`: **Review JSON output format for accuracy.** The JSON output format has been defined. Ensure that the `jsonFormat`, `outJsonPath`, and `responseInfoPath` are correctly specified and match the expected output. --- `57-68`: **Ensure the baseQuery is optimized and correct.** The `baseQuery` for `searchTLApplicationsEODB` is new. Verify that the query is optimized, especially the join condition on `eg_tl_tradelicensedetail` with `additionalDetail->>'CHANNEL'='EODB'`. <details> <summary>Tools</summary> <details> <summary>yamllint</summary><blockquote> [error] 61-61: trailing spaces (trailing-spaces) --- [error] 66-66: trailing spaces (trailing-spaces) --- [error] 67-67: trailing spaces (trailing-spaces) </blockquote></details> </details> --- `76-79`: **Review JSON output format for accuracy.** The JSON output format has been defined. Ensure that the `jsonFormat`, `outJsonPath`, and `responseInfoPath` are correctly specified and match the expected output. --- `82-115`: **Ensure the baseQuery is optimized and correct.** The `baseQuery` for `IFMSintegration` is new and complex. Verify that the query is optimized, especially the use of CTEs and the join conditions. Ensure that the fields and aggregations are correctly implemented. <details> <summary>Tools</summary> <details> <summary>yamllint</summary><blockquote> [error] 113-113: trailing spaces (trailing-spaces) </blockquote></details> </details> --- `119-128`: **Review search parameters for consistency and necessity.** The search parameters have been defined. Ensure that the parameters like `pd.receiptdate` are consistent with the search criteria and necessary for the query. --- `129-134`: **Review JSON output format for accuracy.** The JSON output format has been defined. Ensure that the `jsonFormat`, `outJsonPath`, and `responseInfoPath` are correctly specified and match the expected output. <details> <summary>Tools</summary> <details> <summary>yamllint</summary><blockquote> [error] 129-129: trailing spaces (trailing-spaces) --- [error] 134-134: trailing spaces (trailing-spaces) </blockquote></details> </details> --- `136-143`: **Ensure the baseQuery is optimized and correct.** The `baseQuery` for `GetTenantConfig` is new. Verify that the query is optimized and the fields are correctly implemented. <details> <summary>Tools</summary> <details> <summary>yamllint</summary><blockquote> [error] 140-140: trailing spaces (trailing-spaces) --- [error] 141-141: trailing spaces (trailing-spaces) </blockquote></details> </details> --- `147-152`: **Review search parameters for consistency and necessity.** The search parameters have been defined. Ensure that the parameter `tenantid` is consistent with the search criteria and necessary for the query. --- `154-157`: **Review JSON output format for accuracy.** The JSON output format has been defined. Ensure that the `jsonFormat`, `outJsonPath`, and `responseInfoPath` are correctly specified and match the expected output. --- `161-200`: **Ensure the baseQuery is optimized and correct.** The `baseQuery` for `searchGisMap` is new and complex. Verify that the query is optimized, especially the use of CTEs and the join conditions. Ensure that the fields and aggregations are correctly implemented. <details> <summary>Tools</summary> <details> <summary>yamllint</summary><blockquote> [error] 175-175: trailing spaces (trailing-spaces) --- [error] 176-176: trailing spaces (trailing-spaces) </blockquote></details> </details> --- `204-209`: **Review search parameters for consistency and necessity.** The search parameters have been defined. Ensure that the parameter `surveyid` is consistent with the search criteria and necessary for the query. --- `211-214`: **Review JSON output format for accuracy.** The JSON output format has been defined. Ensure that the `jsonFormat`, `outJsonPath`, and `responseInfoPath` are correctly specified and match the expected output. </blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- configs/egov-searcher/rainmaker-pt-gissearch.yml (1 hunks)
Additional context used
yamllint
configs/egov-searcher/rainmaker-pt-gissearch.yml
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
[error] 75-75: trailing spaces
(trailing-spaces)
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
[error] 158-158: trailing spaces
(trailing-spaces)
[error] 159-159: trailing spaces
(trailing-spaces)
[error] 160-160: trailing spaces
(trailing-spaces)
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 210-210: trailing spaces
(trailing-spaces)
Additional comments not posted (8)
configs/egov-searcher/rainmaker-pt-gissearch.yml (8)
12-21: Ensure the correctness of added fields.The added fields in the
baseQueryseem correct, but verify that:
concat(pt.propertyid , '/' , pt.surveyid) as primarykeygenerates unique keys.getfinancialyearforgis(pd.billid)is a valid function.to_timestamp(cast(pd.receiptdate/1000 as bigint))::datecorrectly converts the timestamp.pt.landareais appropriately handled asplotarea.
22-26: Verify the join conditions.The join conditions have been modified. Ensure that:
- Joins with
egcl_paymentdetail,egcl_bill,eg_pt_property,eg_pt_address, andeg_bndry_mohallaare valid and optimized.- The condition
((pt.oldpropertyid IS NOT NULL AND pt.oldpropertyid != '') OR pt.surveyid is not null)is correct and necessary.
33-38: Verify the search parameters.The search parameters have been modified and added. Ensure that:
pd.receiptdateparameters are correctly defined with appropriatejsonPathandoperator.- The new parameter
bn.blocknameis correctly defined and necessary.Also applies to: 45-48
51-54: Ensure the correctness of the JSON format and paths.The JSON format and paths seem correct, but verify that:
jsonFormatis correctly structured.outJsonPathandresponseInfoPathare correctly defined and used.
62-68: Ensure the correctness of added fields and join conditions.The added fields and join conditions seem correct, but verify that:
- The fields
tl.applicationnumber,tld.additionalDetail::text,tl.status,additionalDetail->>'IPIN',additionalDetail->>'APPID',additionalDetail->>'mobileNp'are correctly defined and necessary.- The join condition
inner join eg_tl_tradelicensedetail tld on tld.tradelicenseid=tl.id and tld.additionalDetail->>'CHANNEL'='EODB'is valid and optimized.Tools
yamllint
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
88-115: Ensure the correctness of added fields and join conditions.The added fields and join conditions seem correct, but verify that:
- The fields
pd.receiptnumber,payment.paidby,bill.consumercode,pd.amountpaid,pd.businessservice,pd.tenantid,payment.paymentmode,payment.transactionnumber,t.mobile_number,taxheadcode,SUM(adjustedamount) as amountare correctly defined and necessary.- The join conditions with
egcl_billaccountdetail,egcl_billdetial,egcl_bill,egcl_paymentdetail,egcl_payment,eg_pg_transactionsare valid and optimized.Tools
yamllint
[error] 113-113: trailing spaces
(trailing-spaces)
121-128: Verify the search parameters.The search parameters have been added. Ensure that:
pd.receiptdateparameters are correctly defined with appropriatejsonPathandoperator.
176-199: Ensure the correctness of added fields and join conditions.The added fields and join conditions seem correct, but verify that:
- The fields
surveyid,split_part(surveyid,'-',1) as town,split_part(surveyid,'-',2) as sector,split_part(surveyid,'-',3) as subsector,rp.tenantid as city,rp.propertyid as property_id,oldpropertyid,builtup_area,plotsize as land_area,nooffloors,propertyusagetype as usage_category,occupancy,ownershipcategory,assessmentyears as financial_year,rpay.amoutpaid as amunt_paid,rpay.receiptdate as date_of_paymentare correctly defined and necessary.- The join conditions with
report_units,report_properties,report_assessments,report_paymentsare valid and optimized.Tools
yamllint
[error] 176-176: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (16)
configs/egov-searcher/rainmaker-pt-gissearch.yml (16)
61-61: Remove trailing spaces.Trailing spaces found on this line.
- select array_to_json(array_agg(row_to_json(data))) from ( + select array_to_json(array_agg(row_to_json(data))) from (Tools
yamllint
[error] 61-61: trailing spaces
(trailing-spaces)
66-66: Remove trailing spaces.Trailing spaces found on this line.
- additionalDetail->>'mobileNo' as mobileNp + additionalDetail->>'mobileNo' as mobileNpTools
yamllint
[error] 66-66: trailing spaces
(trailing-spaces)
67-67: Remove trailing spaces.Trailing spaces found on this line.
- from eg_tl_tradelicense tl + from eg_tl_tradelicense tlTools
yamllint
[error] 67-67: trailing spaces
(trailing-spaces)
75-75: Remove trailing spaces.Trailing spaces found on this line.
- +Tools
yamllint
[error] 75-75: trailing spaces
(trailing-spaces)
113-113: Remove trailing spaces.Trailing spaces found on this line.
- +Tools
yamllint
[error] 113-113: trailing spaces
(trailing-spaces)
129-129: Remove trailing spaces.Trailing spaces found on this line.
- +Tools
yamllint
[error] 129-129: trailing spaces
(trailing-spaces)
134-134: Remove trailing spaces.Trailing spaces found on this line.
- +Tools
yamllint
[error] 134-134: trailing spaces
(trailing-spaces)
140-140: Remove trailing spaces.Trailing spaces found on this line.
- select id,tenantid,locality,issurveyidmandatory + select id,tenantid,locality,issurveyidmandatoryTools
yamllint
[error] 140-140: trailing spaces
(trailing-spaces)
141-141: Remove trailing spaces.Trailing spaces found on this line.
- from eg_tenant_config + from eg_tenant_configTools
yamllint
[error] 141-141: trailing spaces
(trailing-spaces)
153-153: Remove trailing spaces.Trailing spaces found on this line.
- +Tools
yamllint
[error] 153-153: trailing spaces
(trailing-spaces)
158-158: Remove trailing spaces.Trailing spaces found on this line.
- +Tools
yamllint
[error] 158-158: trailing spaces
(trailing-spaces)
159-159: Remove trailing spaces.Trailing spaces found on this line.
- +Tools
yamllint
[error] 159-159: trailing spaces
(trailing-spaces)
160-160: Remove trailing spaces.Trailing spaces found on this line.
- +Tools
yamllint
[error] 160-160: trailing spaces
(trailing-spaces)
175-175: Remove trailing spaces.Trailing spaces found on this line.
- +Tools
yamllint
[error] 175-175: trailing spaces
(trailing-spaces)
176-176: Remove trailing spaces.Trailing spaces found on this line.
- +Tools
yamllint
[error] 176-176: trailing spaces
(trailing-spaces)
210-210: Remove trailing spaces.Trailing spaces found on this line.
- +Tools
yamllint
[error] 210-210: trailing spaces
(trailing-spaces)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- configs/egov-searcher/rainmaker-pt-gissearch.yml (1 hunks)
Additional context used
yamllint
configs/egov-searcher/rainmaker-pt-gissearch.yml
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
[error] 75-75: trailing spaces
(trailing-spaces)
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
[error] 158-158: trailing spaces
(trailing-spaces)
[error] 159-159: trailing spaces
(trailing-spaces)
[error] 160-160: trailing spaces
(trailing-spaces)
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 210-210: trailing spaces
(trailing-spaces)
Additional comments not posted (6)
configs/egov-searcher/rainmaker-pt-gissearch.yml (6)
51-54: Ensure correctness of output formats.The new output formats seem well-defined, but ensure that:
jsonFormatis correctly structured.outJsonPathandresponseInfoPathare correctly mapped.Verify the correctness of these output formats.
Verification successful
Output formats are correctly defined and mapped.
The
jsonFormat,outJsonPath, andresponseInfoPathare consistently used across multiple configuration files, and their structures appear to be correctly defined.
jsonFormatis correctly structured.outJsonPathandresponseInfoPathare correctly mapped.Locations:
configs/egov-searcher/rainmaker-pt-gissearch.ymlconfigs/egov-searcher/propertyopensearch.ymlconfigs/egov-searcher/rainmaker-pt-customsearch-punjab.ymlconfigs/egov-searcher/PTDemandBasedSearcher.ymlconfigs/egov-searcher/rainmaker-pgr-v2-searcher.ymlconfigs/egov-searcher/localitySearcher.ymlconfigs/egov-searcher/bill-genie.ymlconfigs/egov-searcher/rainmaker-tl.ymlconfigs/egov-indexer/payment-indexer-migration.ymlconfigs/egov-indexer/rainmaker-tl-indexer.ymlconfigs/egov-indexer/water-service.ymlconfigs/egov-indexer/sewerage-service.ymlconfigs/egov-indexer/rainmaker-pt-indexer.ymlconfigs/egov-indexer/rainmaker-firenoc-indexer.ymlconfigs/egov-indexer/property-services-migration.ymlconfigs/egov-indexer/property-services-migration-temp.ymlconfigs/egov-indexer/egov-bpa-indexer.ymlconfigs/egov-indexer/property-services.ymlconfigs/egov-indexer/rainmaker-bpastakeholder-indexer.ymlconfigs/egov-indexer/rainmaker-pgr-indexer.ymlconfigs/egov-indexer/collection-indexer.ymlScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the new output formats. # Test: Check the presence and correctness of the output formats in the codebase. Expect: Output formats are present and correctly mapped. rg --type yaml 'jsonFormat|outJsonPath|responseInfoPath'Length of output: 116491
22-27: Validate the new join conditions.The new join conditions in the
baseQueryseem accurate, but ensure that:
- The join between
egcl_paymentdetailandegcl_billonpd.billid=egcl_bill.idis valid.- The join between
eg_pt_propertyandegcl_billonpt.propertyid = egcl_bill.consumercodeis correct.- The join conditions for
eg_pt_addressandeg_bndry_mohallaare appropriate.Verify these join conditions in the database.
12-21: Ensure correctness of the new fields in the query.The new fields added to the
baseQueryseem correct, but ensure that:
concat(pt.propertyid , '/' , pt.surveyid) as primarykeycorrectly forms a unique key.pd.amountpaidandpt.landareaare correctly retrieved from the respective tables.getfinancialyearforgis(pd.billid)correctly returns the financial year.bn.blocknameandto_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdateare correctly formatted.Verify the correctness of these fields in the database.
Verification successful
The new fields in the query are correctly included and formatted.
The fields
concat(pt.propertyid , '/' , pt.surveyid) as primarykey,pd.amountpaid,pt.landarea,getfinancialyearforgis(pd.billid),bn.blockname, andto_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdateare correctly included in the query as per the fileconfigs/egov-searcher/rainmaker-pt-gissearch.yml.
concat(pt.propertyid , '/' , pt.surveyid) as primarykeycorrectly forms a unique key.pd.amountpaidandpt.landareaare correctly retrieved from the respective tables.getfinancialyearforgis(pd.billid)correctly returns the financial year.bn.blocknameandto_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdateare correctly formatted.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the new fields in the query. # Test: Check the presence of the new fields in the database. Expect: Fields are present and correctly formatted. rg --type sql 'concat\(pt\.propertyid , '/' , pt\.surveyid\) as primarykey|pd\.amountpaid|pt\.landarea|getfinancialyearforgis\(pd\.billid\)|bn\.blockname|to_char\(to_timestamp\(cast\(pd\.receiptdate/1000 as bigint\)\)::date , 'dd/mm/yyyy'\) as receiptdate'Length of output: 403
Script:
#!/bin/bash # Description: Verify the correctness of the new fields in the query. # Test: Check the presence of the new fields in the database. Expect: Fields are present and correctly formatted. rg 'concat\(pt\.propertyid , / , pt\.surveyid\) as primarykey|pd\.amountpaid|pt\.landarea|getfinancialyearforgis\(pd\.billid\)|bn\.blockname|to_char\(to_timestamp\(cast\(pd\.receiptdate/1000 as bigint\)\)::date , dd/mm/yyyy\) as receiptdate'Length of output: 1844
82-134: Ensure correctness and completeness of the new function.The new function
IFMSintegrationseems well-defined, but ensure that:
- The
baseQuerycorrectly retrieves the necessary fields.- The search parameters are correctly defined and functional.
- The output formats are correctly structured and mapped.
Verify the correctness and completeness of this new function.
Verification successful
The
IFMSintegrationfunction is correctly defined and appears complete.The
baseQuery, search parameters, and output formats have been verified and are appropriately structured.
- The SQL query in
baseQueryretrieves the necessary fields and includes proper joins.- The search parameters are correctly defined with the appropriate conditions.
- The output formats are well-structured and mapped correctly.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness and completeness of the new function. # Test: Check the presence and correctness of the new function in the codebase. Expect: Function is present and correctly defined. rg --type yaml 'IFMSintegration'Length of output: 106
Script:
#!/bin/bash # Description: Verify the correctness of the baseQuery, search parameters, and output formats in the IFMSintegration function. # Test 1: Verify the structure of the SQL query in the baseQuery. rg --type yaml -A 30 'baseQuery: \|' configs/egov-searcher/rainmaker-pt-gissearch.yml # Test 2: Verify the search parameters defined under the searchParams section. rg --type yaml -A 10 'searchParams:' configs/egov-searcher/rainmaker-pt-gissearch.yml # Test 3: Verify the output format defined under the output section. rg --type yaml -A 10 'output:' configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 8127
Tools
yamllint
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
136-157: Ensure correctness and completeness of the new function.The new function
GetTenantConfigseems well-defined, but ensure that:
- The
baseQuerycorrectly retrieves the necessary fields.- The search parameters are correctly defined and functional.
- The output formats are correctly structured and mapped.
Verify the correctness and completeness of this new function.
Tools
yamllint
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
33-48: Ensure completeness of search parameters.The new search parameters seem well-defined, but ensure that:
pd.receiptdateparameters forfromDateandtoDateare correctly mapped and functional.pt.tenantidis correctly mapped and mandatory.bn.blocknameis correctly mapped and functional.Verify the functionality of these search parameters.
Verification successful
Ensure functionality of search parameters.
The search parameters
pd.receiptdate,pt.tenantid, andbn.blocknameare present in the configuration files. To verify their functionality, ensure these parameters are correctly mapped and used within the codebase. Specifically:
pd.receiptdateforfromDateandtoDatept.tenantidas mandatorybn.blocknameVerify their usage and correct mapping within the codebase.
Ensure functionality of search parameters in
configs/egov-searcher/rainmaker-pt-gissearch.yml.The search parameters
pd.receiptdate,pt.tenantid, andbn.blocknameare present and mapped in the configuration files. To ensure their functionality, verify their specific usage and context in theconfigs/egov-searcher/rainmaker-pt-gissearch.ymlfile.
Search parameters are correctly mapped and functional.
The search parameters
pd.receiptdate,pt.tenantid, andbn.blocknameare present and correctly mapped in theconfigs/egov-searcher/rainmaker-pt-gissearch.ymlfile. Their extensive usage in other configuration files further confirms their functionality.
pd.receiptdateparameters forfromDateandtoDateare correctly mapped.pt.tenantidis correctly mapped and mandatory.bn.blocknameis correctly mapped.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the functionality of the new search parameters. # Test: Check the presence and functionality of the search parameters in the codebase. Expect: Parameters are present and functional. rg --type yaml 'pd\.receiptdate|pt\.tenantid|bn\.blockname'Length of output: 15666
Script:
#!/bin/bash # Verify correct mapping and usage of the search parameters in the codebase. # Check the usage of `pd.receiptdate` for `fromDate` and `toDate` in the codebase. rg 'pd\.receiptdate' # Check the usage of `pt.tenantid` in the codebase. rg 'pt\.tenantid' # Check the usage of `bn.blockname` in the codebase. rg 'bn\.blockname'Length of output: 15668
Script:
#!/bin/bash # Verify the specific usage and context of search parameters in the target file. # Check the usage of `pd.receiptdate`, `pt.tenantid`, and `bn.blockname` in `configs/egov-searcher/rainmaker-pt-gissearch.yml`. rg 'pd\.receiptdate|pt\.tenantid|bn\.blockname' configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 423
| - name: searchGisMap | ||
| query: | ||
| baseQuery: | | ||
| select array_to_json(array_agg(row_to_json(data))) from ( | ||
| with units as | ||
| ( | ||
| select | ||
| propertyuuid, | ||
| string_agg(occupancytype,',') as occupancy, | ||
| sum(builtuparea) as builtup_area | ||
| from report_units | ||
| where propertyuuid in (select pt_uuid from report_properties $where) | ||
| group by propertyuuid | ||
| ) | ||
| select | ||
| surveyid, | ||
| split_part(surveyid,'-',1) as town, | ||
| split_part(surveyid,'-',2) as sector, | ||
| split_part(surveyid,'-',3) as subsector, | ||
| 'plot' as plot, | ||
| rp.tenantid as city, | ||
| rp.propertyid as property_id, | ||
| oldpropertyid as oldpropertyid, | ||
| 'uidno' as uid_no, | ||
| 'blockcode' as wardno, | ||
| builtup_area as builtup_area, | ||
| plotsize as land_area, | ||
| 'area' as area, | ||
| nooffloors as no_of_floors, | ||
| propertyusagetype as usage_category, | ||
| occupancy as occupancy, | ||
| ownershipcategory as ownership_category, | ||
| assessmentyears as financial_year, | ||
| rpay.amoutpaid as amunt_paid, | ||
| rpay.receiptdate as date_of_payment | ||
| from report_properties rp | ||
| inner join units ru on rp.pt_uuid=ru.propertyuui | ||
| inner join report_assessments ra on ra.propertyid=rp.propertyid | ||
| inner join report_payments rpay on (rpay.propertyid=rp.propertyid and rpay.amoutpaid=ra.amount) | ||
| $where) data | ||
| groupBy: | ||
| orderBy: | ||
| searchParams: | ||
| condition: AND | ||
| params: | ||
| - name: surveyid | ||
| isMandatory: true | ||
| jsonPath: $.searchCriteria.plot_map_id | ||
| operator: = | ||
|
|
||
| output: | ||
| jsonFormat: {"ResponseInfo": {}} | ||
| outJsonPath: $.data | ||
| responseInfoPath: $.ResponseInfo |
There was a problem hiding this comment.
Tip
Codebase Verification
Potential Typo in SQL Query and Verification of Search Parameters and Output Formats
The searchGisMap function is well-defined, but there is a potential typo in the SQL query:
- SQL Query: The join condition
inner join units ru on rp.pt_uuid=ru.propertyuuilikely contains a typo. It should berp.pt_uuid=ru.propertyuuid.
The search parameters and output formats are correctly structured and mapped.
-
Search Parameters:
surveyidis mandatory and mapped to$.searchCriteria.plot_map_id.- Other parameters are correctly defined in the context.
-
Output Formats:
jsonFormatis correctly structured with{"ResponseInfo": {}}.outJsonPathis set to$.data.responseInfoPathis set to$.ResponseInfo.
Please address the potential typo in the SQL query.
- File:
configs/egov-searcher/rainmaker-pt-gissearch.yml - Lines: 161-214
Analysis chain
Ensure correctness and completeness of the new function.
The new function searchGisMap seems well-defined, but ensure that:
- The
baseQuerycorrectly retrieves the necessary fields. - The search parameters are correctly defined and functional.
- The output formats are correctly structured and mapped.
Verify the correctness and completeness of this new function.
To ensure the correctness and completeness of the searchGisMap function, we need to verify the SQL query syntax, the search parameters, and the output formats. Let's proceed with generating scripts to check these aspects.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the correctness and completeness of the new function.
# Test: Check the presence and correctness of the new function in the codebase. Expect: Function is present and correctly defined.
rg --type yaml 'searchGisMap'
Length of output: 100
Script:
#!/bin/bash
# Description: Verify the SQL query syntax, search parameters, and output formats in the searchGisMap function.
# Test 1: Check the SQL query syntax for common SQL keywords and structure issues.
rg --type yaml 'baseQuery:.*select' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.yml
# Test 2: Verify the search parameters are correctly defined.
rg --type yaml 'searchParams:' -A 10 configs/egov-searcher/rainmaker-pt-gissearch.yml
# Test 3: Verify the output formats are correctly structured and mapped.
rg --type yaml 'output:' -A 10 configs/egov-searcher/rainmaker-pt-gissearch.yml
Length of output: 2581
Tools
yamllint
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 210-210: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Actionable comments posted: 6
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- configs/egov-searcher/rainmaker-pt-gissearch.yml (1 hunks)
Additional context used
yamllint
configs/egov-searcher/rainmaker-pt-gissearch.yml
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
[error] 75-75: trailing spaces
(trailing-spaces)
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
[error] 158-158: trailing spaces
(trailing-spaces)
[error] 159-159: trailing spaces
(trailing-spaces)
[error] 160-160: trailing spaces
(trailing-spaces)
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 210-210: trailing spaces
(trailing-spaces)
Additional comments not posted (6)
configs/egov-searcher/rainmaker-pt-gissearch.yml (6)
197-197: Fix potential typo in SQL query.The join condition
inner join units ru on rp.pt_uuid=ru.propertyuuidlikely contains a typo. It should berp.pt_uuid=ru.propertyuuid.- inner join units ru on rp.pt_uuid=ru.propertyuuid + inner join units ru on rp.propertyuuid=ru.propertyuuidLikely invalid or redundant comment.
12-27: Verify correctness of SQL query and joins.Ensure that the field names and join conditions are correct and functional.
57-71: Verify correctness of SQL query and joins.Ensure that the field names and join conditions are correct and functional.
Verification successful
SQL Query and Joins Verified
The SQL query and join conditions in the
searchTLApplicationsEODBdefinition are correct. The fields and join conditions used in the query match those found in other parts of the codebase.
eg_tl_tradelicensetable and its fields (applicationnumber,status,id) are used correctly.eg_tl_tradelicensedetailtable and its fields (tradelicenseid,additionalDetail) are used correctly.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of SQL query and joins in searchTLApplicationsEODB definition. # Test: Search for the usage of field names and join conditions. Expect: Correct field names and join conditions. rg --type yaml 'searchTLApplicationsEODB' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 753
Script:
#!/bin/bash # Search for the definition of the table eg_tl_tradelicense and its fields rg --type sql 'CREATE TABLE.*eg_tl_tradelicense' # Search for the definition of the table eg_tl_tradelicensedetail and its fields rg --type sql 'CREATE TABLE.*eg_tl_tradelicensedetail'Length of output: 405
Script:
#!/bin/bash # Search for any mention of the table eg_tl_tradelicense in the repository rg 'eg_tl_tradelicense' # Search for any mention of the table eg_tl_tradelicensedetail in the repository rg 'eg_tl_tradelicensedetail'Length of output: 49258
Tools
yamllint
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
82-115: Verify correctness of SQL query and joins.Ensure that the field names and join conditions are correct and functional.
Tools
yamllint
[error] 113-113: trailing spaces
(trailing-spaces)
161-200: Verify correctness of SQL query and joins.Ensure that the field names and join conditions are correct and functional.
Tools
yamllint
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
136-157: Verify correctness of SQL query and joins.Ensure that the field names and join conditions are correct and functional.
Tools
yamllint
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
| query: | ||
| baseQuery: | | ||
| select array_to_json(array_agg(row_to_json(data))) from ( | ||
| select |
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces reduce readability and should be removed.
- select
+ select
- tl.status,additionalDetail->>'IPIN' as iPin,
+ tl.status,additionalDetail->>'IPIN' as iPin,
- additionalDetail->>'mobileNo' as mobileNp
+ additionalDetail->>'mobileNo' as mobileNp
-
+Also applies to: 66-67, 75-75
Tools
yamllint
[error] 61-61: trailing spaces
(trailing-spaces)
Remove trailing spaces.
Trailing spaces reduce readability and should be removed.
- select
+ select
- tl.status,additionalDetail->>'IPIN' as iPin,
+ tl.status,additionalDetail->>'IPIN' as iPin,
- additionalDetail->>'mobileNo' as mobileNp
+ additionalDetail->>'mobileNo' as mobileNp
-
+Also applies to: 66-67, 75-75
Tools
yamllint
[error] 61-61: trailing spaces
(trailing-spaces)
| - name: searchTLApplicationsEODB | ||
| query: | ||
| baseQuery: | | ||
| select array_to_json(array_agg(row_to_json(data))) from ( | ||
| select | ||
| tl.applicationnumber, | ||
| tld.additionalDetail::text, | ||
| tl.status,additionalDetail->>'IPIN' as iPin, | ||
| additionalDetail->>'APPID' as appId, | ||
| additionalDetail->>'mobileNo' as mobileNp | ||
| from eg_tl_tradelicense tl | ||
| inner join eg_tl_tradelicensedetail tld on tld.tradelicenseid=tl.id and tld.additionalDetail->>'CHANNEL'='EODB' ) data | ||
| groupBy: | ||
| orderBy: | ||
| searchParams: | ||
| condition: AND | ||
| params: | ||
|
|
There was a problem hiding this comment.
Complete the searchParams definition.
The searchParams section in the searchTLApplicationsEODB function is defined but lacks specific parameters. This might affect the functionality of the search.
searchParams:
condition: AND
params:
- name: tl.applicationnumber
isMandatory: true
jsonPath: $.searchCriteria.applicationNumber
operator: =
- name: tld.additionalDetail
isMandatory: false
jsonPath: $.searchCriteria.additionalDetail
operator: LIKE
- name: tl.status
isMandatory: false
jsonPath: $.searchCriteria.status
operator: =
- name: additionalDetail->>'IPIN'
isMandatory: false
jsonPath: $.searchCriteria.iPin
operator: =
- name: additionalDetail->>'APPID'
isMandatory: false
jsonPath: $.searchCriteria.appId
operator: =
- name: additionalDetail->>'mobileNo'
isMandatory: false
jsonPath: $.searchCriteria.mobileNo
operator: =Tools
yamllint
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
| mobile_number, | ||
| json_agg( json_build_object('taxheadcode', taxheadcode,'amount', amount::text)) as taxheads , | ||
| ( case when consumercode like 'PT%' then (select usagecategory from eg_pt_property where propertyid=consumercode and status='ACTIVE') else '' end) as ptype | ||
| from details |
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces reduce readability and should be removed.
- ) as data
+ ) as data
-
+
-
+Also applies to: 129-129, 134-134
Tools
yamllint
[error] 113-113: trailing spaces
(trailing-spaces)
| select id,tenantid,locality,issurveyidmandatory | ||
| from eg_tenant_config |
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces reduce readability and should be removed.
- from eg_tenant_config
+ from eg_tenant_config
-
+
-
+
-
+Also applies to: 153-158
Tools
yamllint
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
| select | ||
| surveyid, |
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces reduce readability and should be removed.
- )
+ )
-
+Also applies to: 210-210
Tools
yamllint
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- configs/egov-searcher/rainmaker-pt-gissearch.yml (1 hunks)
Additional context used
yamllint
configs/egov-searcher/rainmaker-pt-gissearch.yml
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
[error] 75-75: trailing spaces
(trailing-spaces)
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
[error] 158-158: trailing spaces
(trailing-spaces)
[error] 159-159: trailing spaces
(trailing-spaces)
[error] 160-160: trailing spaces
(trailing-spaces)
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 210-210: trailing spaces
(trailing-spaces)
Additional comments not posted (6)
configs/egov-searcher/rainmaker-pt-gissearch.yml (6)
72-74: Complete thesearchParamsdefinition.The
searchParamssection in thesearchTLApplicationsEODBfunction is defined but lacks specific parameters. This might affect the functionality of the search.
51-55: Ensure correctness of theoutputdefinition.The
outputsection has been defined with new JSON output formats. Ensure that:
- The
jsonFormatis correctly structured.- The
outJsonPathandresponseInfoPathare correctly mapped.Verification successful
Ensure correctness of the
outputdefinition.The
outputsection has been defined with new JSON output formats. Ensure that:
- The
jsonFormatis correctly structured.- The
outJsonPathandresponseInfoPathare correctly mapped.The structure of the
outputsection appears consistent across multiple queries in therainmaker-pt-gissearch.ymlfile. However, the correctness of the mappings foroutJsonPathandresponseInfoPathneeds to be verified in the context of the queries.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the output formats. # Test: Verify the output formats are correctly structured and mapped. rg --type yaml 'output:' -A 10 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 1218
33-48: Ensure completeness ofsearchParamsdefinition.The
searchParamssection has been modified. Ensure that:
- The
pd.receiptdateparameter is correctly marked as non-mandatory.- The new parameter
bn.blocknameis correctly defined.Verification successful
Ensure completeness of
searchParamsdefinition.The
searchParamssection has been correctly modified. Thepd.receiptdateparameter is correctly marked as non-mandatory, and the new parameterbn.blocknameis correctly defined.
pd.receiptdatemarked as non-mandatory.bn.blocknamecorrectly defined.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness and completeness of the search parameters. # Test: Verify the search parameters are correctly defined. rg --type yaml 'searchParams:' -A 10 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 1269
Script:
#!/bin/bash # Description: Verify the presence and correctness of the `bn.blockname` parameter. # Test: Search for the `bn.blockname` parameter in the specified YAML file. rg --type yaml 'bn.blockname' -A 5 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 486
164-200: Fix potential typo in SQL query and verify new fields and join conditions.The
searchGisMapfunction is well-defined, but there is a potential typo in the SQL query:
- The join condition
inner join units ru on rp.pt_uuid=ru.propertyuuidlikely contains a typo. It should berp.pt_uuid=ru.propertyuuid.Ensure that:
- The fields
surveyid as plot_map_id,upper(split_part(rp.tenantid,'.',2)) as town,split_part(replace(surveyid,upper(split_part(rp.tenantid,'.',2)),''),'-',2) as sector,split_part(surveyid,'-',2) as subsector,split_part(surveyid,'-',2) as plot,split_part(rp.tenantid,'.',2) as city,rp.propertyid as property_id,oldpropertyid as oldpropertyid,'uidno' as uid_no,blockname as wardno,builtup_area as builtup_area,plotsize as land_area,'area' as area,nooffloors as no_of_floors,propertyusagetype as usage_category,occupancy as occupancy,ownershipcategory as ownership_category,assessmentyears as financial_year,rpay.amoutpaid as amunt_paid,rpay.receiptdate as date_of_paymentare correctly retrieved.- The join conditions with
report_units,report_assessments, andreport_paymentsare accurate.Verification successful
Fix potential typo in SQL query and verify new fields and join conditions.
The
searchGisMapfunction is well-defined, but there is a potential typo in the SQL query:
- The join condition
inner join units ru on rp.pt_uuid=ru.propertyuuidlikely contains a typo. It should berp.pt_uuid=ru.propertyuuid.Ensure that:
- The fields
surveyid as plot_map_id,upper(split_part(rp.tenantid,'.',2)) as town,split_part(replace(surveyid,upper(split_part(rp.tenantid,'.',2)),''),'-',2) as sector,split_part(surveyid,'-',2) as subsector,split_part(surveyid,'-',2) as plot,split_part(rp.tenantid,'.',2) as city,rp.propertyid as property_id,oldpropertyid as oldpropertyid,'uidno' as uid_no,blockname as wardno,builtup_area as builtup_area,plotsize as land_area,'area' as area,nooffloors as no_of_floors,propertyusagetype as usage_category,occupancy as occupancy,ownershipcategory as ownership_category,assessmentyears as financial_year,rpay.amoutpaid as amunt_paid,rpay.receiptdate as date_of_paymentare correctly retrieved.- The join conditions with
report_units,report_assessments, andreport_paymentsare accurate.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of new fields and join conditions in `baseQuery`. # Test: Check the SQL query syntax for common SQL keywords and structure issues. rg --type yaml 'baseQuery:.*select' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Verify the correctness of new fields and join conditions in the specified lines of the YAML file. # Test: Check the SQL query syntax within the specified lines (164-200) for common SQL keywords and structure issues. sed -n '164,200p' configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 1726
Tools
yamllint
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
12-21: Ensure the correctness of new fields and join conditions inbaseQuery.The new fields and join conditions should be verified for correctness. Ensure that:
- The fields
concat(pt.propertyid , '/' , pt.surveyid) as primarykey,pd.amountpaid as amount,getfinancialyearforgis(pd.billid) as financialyear,bn.blockname,to_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdate,pt.landarea as plotareaare correctly retrieved.- The join conditions with
egcl_paymentdetail,egcl_bill,eg_pt_property,eg_pt_address, andeg_bndry_mohallaare accurate.Verification successful
Ensure the correctness of new fields and join conditions in
baseQuery.The new fields and join conditions in the
baseQueryforsearchNewTaxPaymentsare correctly structured. The fields are accurately retrieved, and the join conditions are valid.
concat(pt.propertyid , '/' , pt.surveyid) as primarykeypd.amountpaid as amountgetfinancialyearforgis(pd.billid) as financialyearbn.blocknameto_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdatept.landarea as plotareaThe join conditions with
egcl_paymentdetail,egcl_bill,eg_pt_property,eg_pt_address, andeg_bndry_mohallaare accurate.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of new fields and join conditions in `baseQuery`. # Test: Check the SQL query syntax for common SQL keywords and structure issues. rg --type yaml 'baseQuery:.*select' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Verify the correctness of new fields and join conditions in `baseQuery` for `searchNewTaxPayments`. # Test: Check the SQL query syntax and structure for the `searchNewTaxPayments` section. rg --type yaml 'searchNewTaxPayments:' -A 50 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 93
Script:
#!/bin/bash # Description: Verify the correctness of new fields and join conditions in `baseQuery` for any section. # Test: Check the SQL query syntax and structure for any `baseQuery` pattern in the file. rg --type yaml 'baseQuery:' -A 50 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 7256
61-68: Ensure the correctness of new fields and join conditions inbaseQuery.The new fields and join conditions should be verified for correctness. Ensure that:
- The fields
tl.applicationnumber,tld.additionalDetail::text,tl.status,additionalDetail->>'IPIN' as iPin,additionalDetail->>'APPID' as appId,additionalDetail->>'mobileNo' as mobileNpare correctly retrieved.- The join condition with
eg_tl_tradelicensedetailis accurate.Verification successful
Ensure the correctness of new fields and join conditions in
baseQuery.The
baseQueryinsearchTLApplicationsEODBhas been verified and includes the following fields and join conditions:
- Fields:
tl.applicationnumber,tld.additionalDetail::text,tl.status,additionalDetail->>'IPIN' as iPin,additionalDetail->>'APPID' as appId,additionalDetail->>'mobileNo' as mobileNp.- Join condition:
inner join eg_tl_tradelicensedetail tld on tld.tradelicenseid=tl.id and tld.additionalDetail->>'CHANNEL'='EODB'.The SQL syntax and structure appear to be correct.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of new fields and join conditions in `baseQuery`. # Test: Check the SQL query syntax for common SQL keywords and structure issues. rg --type yaml 'baseQuery:.*select' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Verify the correctness of new fields and join conditions in `baseQuery`. # Test: Check the SQL query syntax for common SQL keywords and structure issues. rg 'baseQuery:.*select' -A 30 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 80
Script:
#!/bin/bash # Description: Verify the presence of `baseQuery` and the specified YAML file in the repository. # Test: Search for any occurrence of `baseQuery` in the entire repository. rg 'baseQuery' -A 30 # Test: Confirm the existence of the specified YAML file. fd 'rainmaker-pt-gissearch.yml'Length of output: 150363
Script:
#!/bin/bash # Description: Verify the SQL query syntax and structure in the `baseQuery` section of the specified YAML file. # Extract the entire `baseQuery` content for detailed inspection. rg 'baseQuery:.*select' -A 30 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 80
Script:
#!/bin/bash # Description: Verify the SQL query syntax and structure in the `baseQuery` section of the specified YAML file. # Extract the entire `baseQuery` content for detailed inspection. rg 'baseQuery:' -A 50 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 7244
Tools
yamllint
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range, codebase verification and nitpick comments (2)
configs/egov-searcher/rainmaker-pt-gissearch.yml (2)
61-67: Remove trailing spaces.Trailing spaces reduce readability and should be removed.
- select + select - tl.status,additionalDetail->>'IPIN' as iPin, + tl.status,additionalDetail->>'IPIN' as iPin, - additionalDetail->>'mobileNo' as mobileNp + additionalDetail->>'mobileNo' as mobileNpTools
yamllint
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
140-141: Remove trailing spaces.Trailing spaces reduce readability and should be removed.
- from eg_tenant_config + from eg_tenant_configTools
yamllint
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- configs/egov-searcher/rainmaker-pt-gissearch.yml (1 hunks)
Additional context used
yamllint
configs/egov-searcher/rainmaker-pt-gissearch.yml
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
[error] 75-75: trailing spaces
(trailing-spaces)
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
[error] 158-158: trailing spaces
(trailing-spaces)
[error] 159-159: trailing spaces
(trailing-spaces)
[error] 160-160: trailing spaces
(trailing-spaces)
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 214-214: trailing spaces
(trailing-spaces)
Additional comments not posted (6)
configs/egov-searcher/rainmaker-pt-gissearch.yml (6)
161-214: Potential Typo in SQL Query and Verification of Search Parameters and Output FormatsThe
searchGisMapfunction is well-defined, but there is a potential typo in the SQL query:
- SQL Query: The join condition
inner join units ru on rp.pt_uuid=ru.propertyuuidlikely contains a typo. It should berp.pt_uuid=ru.propertyuuid.The search parameters and output formats are correctly structured and mapped.
Search Parameters:
surveyidis mandatory and mapped to$.searchCriteria.plot_map_id.- Other parameters are correctly defined in the context.
Output Formats:
jsonFormatis correctly structured with{"ResponseInfo": {}}.outJsonPathis set to$.data.responseInfoPathis set to$.ResponseInfo.Please address the potential typo in the SQL query.
- inner join units ru on rp.pt_uuid=ru.propertyuuid + inner join units ru on rp.pt_uuid=ru.propertyuuidLikely invalid or redundant comment.
Tools
yamllint
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 214-214: trailing spaces
(trailing-spaces)
121-128: Ensure search parameters are correctly defined.The
searchParamssection includes new parameters. Verify thatpd.receiptdateis correctly defined and mapped to the appropriate JSON paths.Verification successful
Ensure search parameters are correctly defined.
The
searchParamssection includes parameters with the namepd.receiptdatedefined twice. Verify that these parameters are correctly mapped to the appropriate JSON paths and there are no conflicts.
pd.receiptdatewithjsonPath: $.searchCriteria.fromDateandoperator: GEpd.receiptdatewithjsonPath: $.searchCriteria.toDateandoperator: LEScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the search parameters. # Test: Check the presence and correctness of the search parameters. Expect: Search parameters are correctly defined and mapped. rg --type yaml 'searchParams:' -A 10 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 1298
33-48: Ensure search parameters are correctly defined.The
searchParamssection includes new parameters. Verify thatpd.receiptdateandbn.blocknameare correctly defined and mapped to the appropriate JSON paths.Verification successful
The search parameters
pd.receiptdateandbn.blocknameare correctly defined and mapped to the appropriate JSON paths.
pd.receiptdateis mapped to$.searchCriteria.fromDateand$.searchCriteria.toDate.bn.blocknameis mapped to$.searchCriteria.blockcode.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the search parameters. # Test: Check the presence and correctness of the search parameters. Expect: Search parameters are correctly defined and mapped. rg --type yaml 'searchParams:' -A 10 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 1298
Script:
#!/bin/bash # Description: Verify the presence and correctness of the `bn.blockname` parameter and ensure `pd.receiptdate` is correctly mapped. # Test: Check for the `bn.blockname` parameter in the YAML file. rg --type yaml 'bn.blockname' -A 5 configs/egov-searcher/rainmaker-pt-gissearch.yml # Test: Check for the `pd.receiptdate` parameter and its mappings in the YAML file. rg --type yaml 'pd.receiptdate' -A 5 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 1507
85-115: Verify correctness of the new fields in the base query.The new fields added to the base query should be verified for correctness and relevance.
Verification successful
The new fields in the base query are correctly defined and used.
The fields added to the base query in the
IFMSintegrationsection are appropriate and correctly implemented.
receiptnumberpaidbyconsumercodeamountpaidbusinessservicetenantidpaymentmodetransactionNomobile_numbertaxheadcode- Subquery for
ptypeScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the new fields in the base query. # Test: Check the presence and correctness of the new fields in the base query. Expect: Fields are correctly defined and used. rg --type yaml 'baseQuery:.*select' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Verify the correctness of the new fields in the base query. # Test: Check the presence and correctness of the new fields in the base query. Expect: Fields are correctly defined and used. rg --type yaml 'select.*from' -A 50 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 7419
Tools
yamllint
[error] 113-113: trailing spaces
(trailing-spaces)
22-27: Review the modified join conditions.The join conditions have been modified and additional joins added. Ensure that the join conditions are correct and necessary for the query.
12-21: Verify correctness of the new fields in the base query.The new fields added to the base query should be verified for correctness and relevance. Ensure that
concat(pt.propertyid , '/' , pt.surveyid) as primarykey,pd.amountpaid as amount,getfinancialyearforgis(pd.billid) as financialyear,bn.blockname,to_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdate, andpt.landarea as plotareaare correctly defined and used.Verification successful
The new fields in the base query are correctly defined and used.
The fields
concat(pt.propertyid , '/' , pt.surveyid) as primarykey,pt.oldpropertyid as oldpropertyid,pt.surveyid as surveyid,pd.amountpaid as amount,getfinancialyearforgis(pd.billid) as financialyear,bn.blockname,pt.tenantid as tenantid,pd.receiptnumber as receiptnumber,to_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdate, andpt.landarea as plotareaare correctly defined and used in the base query.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the new fields in the base query. # Test: Check the presence and correctness of the new fields in the base query. Expect: Fields are correctly defined and used. rg --type yaml 'baseQuery:.*select' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Verify the correctness of the new fields in the base query using ast-grep. # Test: Check the presence and correctness of the new fields in the base query. Expect: Fields are correctly defined and used. ast-grep --lang yaml --pattern $'baseQuery: select concat(pt.propertyid , \'/\' , pt.surveyid) as primarykey, pt.oldpropertyid as oldpropertyid, pt.surveyid as surveyid, pd.amountpaid as amount, getfinancialyearforgis(pd.billid) as financialyear, bn.blockname, pt.tenantid as tenantid, pd.receiptnumber as receiptnumber, to_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , \'dd/mm/yyyy\') as receiptdate, pt.landarea as plotarea' configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 630
Script:
#!/bin/bash # Description: Verify the correctness of the new fields in the base query using rg with more context lines. # Test: Check the presence and correctness of the new fields in the base query. Expect: Fields are correctly defined and used. rg --type yaml 'baseQuery:.*select' -A 50 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Verify the correctness of the new fields in the base query using rg without limiting context lines. # Test: Check the presence and correctness of the new fields in the base query. Expect: Fields are correctly defined and used. rg --type yaml 'baseQuery:.*select' -A 100 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 93
Script:
#!/bin/bash # Description: Verify the correctness of the new fields in the base query using rg to search for the `searchNewTaxPayments` keyword. # Test: Check the presence and correctness of the new fields in the base query. Expect: Fields are correctly defined and used. rg --type yaml 'searchNewTaxPayments' -A 100 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 3887
There was a problem hiding this comment.
Actionable comments posted: 5
Outside diff range, codebase verification and nitpick comments (1)
configs/egov-searcher/rainmaker-pt-gissearch.yml (1)
12-21: Missing fields in the base queryThe fields
concat(pt.propertyid , '/' , pt.surveyid) as primarykeyandto_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdateare not found in theconfigs/egov-searcher/rainmaker-pt-gissearch.ymlfile. Please ensure these fields are correctly defined and included in the base query.
concat(pt.propertyid , '/' , pt.surveyid) as primarykeyto_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdateAnalysis chain
Ensure correctness of the new fields in the base query.
The new fields added to the base query should be verified for correctness. Ensure that
concat(pt.propertyid , '/' , pt.surveyid) as primarykey,pd.amountpaid as amount,getfinancialyearforgis(pd.billid) as financialyear,bn.blockname,to_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdate, andpt.landarea as plotareaare correctly retrieving and formatting the necessary data.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the new fields in the base query. # Test: Check the SQL query for the presence of the new fields. Expect: Fields are correctly defined. rg --type yaml 'baseQuery:.*select' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Verify the presence and correctness of the new fields in the base query. # Test: Check for the presence of each new field in the base query. rg 'concat\(pt\.propertyid , '/' , pt\.surveyid\) as primarykey' configs/egov-searcher/rainmaker-pt-gissearch.yml rg 'pd\.amountpaid as amount' configs/egov-searcher/rainmaker-pt-gissearch.yml rg 'getfinancialyearforgis\(pd\.billid\) as financialyear' configs/egov-searcher/rainmaker-pt-gissearch.yml rg 'bn\.blockname' configs/egov-searcher/rainmaker-pt-gissearch.yml rg 'to_char\(to_timestamp\(cast\(pd\.receiptdate/1000 as bigint\)\)::date , 'dd/mm/yyyy'\) as receiptdate' configs/egov-searcher/rainmaker-pt-gissearch.yml rg 'pt\.landarea as plotarea' configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 795
Script:
#!/bin/bash # Description: Verify the presence of the missing fields in the base query. # Test: Check for the presence of the missing fields in the base query. rg 'concat\(pt\.propertyid , '/' , pt\.surveyid\) as primarykey' configs/egov-searcher/rainmaker-pt-gissearch.yml rg 'to_char\(to_timestamp\(cast\(pd\.receiptdate/1000 as bigint\)\)::date , 'dd/mm/yyyy'\) as receiptdate' configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 269
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- configs/egov-searcher/rainmaker-pt-gissearch.yml (1 hunks)
Additional context used
yamllint
configs/egov-searcher/rainmaker-pt-gissearch.yml
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
[error] 75-75: trailing spaces
(trailing-spaces)
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
[error] 158-158: trailing spaces
(trailing-spaces)
[error] 159-159: trailing spaces
(trailing-spaces)
[error] 160-160: trailing spaces
(trailing-spaces)
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 214-214: trailing spaces
(trailing-spaces)
Additional comments not posted (4)
configs/egov-searcher/rainmaker-pt-gissearch.yml (4)
121-128: Ensure completeness of thesearchParamsdefinition.The
searchParamssection includes modifications to thepd.receiptdateparameter. Ensure that these parameters are correctly defined and functional.
33-48: Ensure completeness of thesearchParamsdefinition.The
searchParamssection includes modifications to thepd.receiptdateparameter and the addition of a new parameterbn.blockname. Ensure that these parameters are correctly defined and functional.Verification successful
The
searchParamsdefinition is complete and correctly includes thepd.receiptdateandbn.blocknameparameters.
pd.receiptdateparameters are defined withjsonPathset to$.searchCriteria.fromDateand$.searchCriteria.toDate.bn.blocknameparameter is defined withjsonPathset to$.searchCriteria.blockcode.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the completeness of the `searchParams` definition. # Test: Check the presence and correctness of the search parameters. Expect: Parameters are correctly defined. rg --type yaml 'searchParams:' -A 10 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 1298
Script:
#!/bin/bash # Description: Verify the presence and correctness of the `bn.blockname` parameter within the `searchParams` sections. # Test: Search for the `bn.blockname` parameter in the YAML file. rg --type yaml 'bn.blockname' -A 5 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 486
85-115: Ensure correctness of the new fields in the base query.The new fields added to the base query should be verified for correctness. Ensure that the fields in the
detailsCTE and the final select statement are correctly retrieving and formatting the necessary data.Verification successful
Ensure correctness of the new fields in the base query.
The new fields added to the base query in the
detailsCTE and the final select statement appear to be correctly retrieving and formatting the necessary data. The fields includepd.receiptnumber,payment.paidby,bill.consumercode,pd.amountpaid,pd.businessservice,pd.tenantid,payment.paymentmode,payment.transactionnumber,t.mobile_number,taxheadcode, andSUM(adjustedamount) as amount. The final select statement includes the same fields and additional processing fortaxheadsandptype.
detailsCTE: Fields are correctly defined and grouped.- Final select statement: Fields are correctly selected and formatted.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the new fields in the base query. # Test: Check the SQL query for the presence of the new fields. Expect: Fields are correctly defined. rg --type yaml 'baseQuery:.*select' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Verify the correctness of the new fields in the base query. # Test: Check the SQL query for the presence of the new fields. Expect: Fields are correctly defined. rg --type yaml 'select.*array_to_json' -A 50 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 7273
Tools
yamllint
[error] 113-113: trailing spaces
(trailing-spaces)
22-27: Verify join conditions and additional conditions.The join conditions and additional conditions in the base query should be verified for correctness. Ensure that the joins with
egcl_paymentdetail,egcl_bill,eg_pt_property,eg_pt_address, andeg_bndry_mohallaare correctly defined and that the additional conditions are valid.Verification successful
Verify join conditions and additional conditions.
The join conditions and additional conditions in the base query appear to be correctly defined. Here are the key points of verification:
INNER JOIN egcl_bill on pd.billid=egcl_bill.idINNER JOIN eg_pt_property AS pt ON pt.propertyid = egcl_bill.consumercode AND ((pt.oldpropertyid IS NOT NULL AND pt.oldpropertyid != '') OR pt.surveyid is not null)INNER JOIN eg_pt_address As ad ON ad.propertyid=pt.id and ad.lastmodifiedtime in (select max(lastmodifiedtime) from eg_pt_address where propertyid=pt.id)INNER JOIN eg_bndry_mohalla As bn ON ad.locality=bn.localitycode and ad.tenantid=bn.tenantidThese join conditions are logically sound and correctly defined based on the provided query.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the join conditions and additional conditions in the base query. # Test: Check the SQL query for the presence of the join conditions. Expect: Joins are correctly defined. rg --type yaml 'baseQuery:.*select' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Verify the join conditions and additional conditions in the base query. # Test: Check the SQL query for the presence of the join conditions. Expect: Joins are correctly defined. rg --type yaml 'baseQuery:.*select' -A 50 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Search for any SQL-like patterns within the YAML file to capture the query and verify the join conditions. # Test: Check the SQL query for the presence of join conditions. Expect: Joins are correctly defined. rg --type yaml 'select .* from' -A 50 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 7424
| condition: AND | ||
| params: | ||
| - name: tenantid | ||
| isMandatory: true | ||
| jsonPath: $.searchCriteria.tenantId | ||
| operator: = |
There was a problem hiding this comment.
Complete the searchParams definition.
The searchParams section is defined but lacks specific parameters. This might affect the functionality of the search.
searchParams:
condition: AND
params:
- name: tenantid
isMandatory: true
jsonPath: $.searchCriteria.tenantId
operator: =| select id,tenantid,locality,issurveyidmandatory | ||
| from eg_tenant_config | ||
| $where | ||
| ) data |
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces reduce readability and should be removed.
- from eg_tenant_config
+ from eg_tenant_configCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| select id,tenantid,locality,issurveyidmandatory | |
| from eg_tenant_config | |
| $where | |
| ) data | |
| select id,tenantid,locality,issurveyidmandatory | |
| from eg_tenant_config | |
| $where | |
| ) data |
Tools
yamllint
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
| select | ||
| tl.applicationnumber, | ||
| tld.additionalDetail::text, | ||
| tl.status,additionalDetail->>'IPIN' as iPin, | ||
| additionalDetail->>'APPID' as appId, | ||
| additionalDetail->>'mobileNo' as mobileNp | ||
| from eg_tl_tradelicense tl |
There was a problem hiding this comment.
Remove trailing spaces.
Trailing spaces reduce readability and should be removed.
- select
+ select
- tl.status,additionalDetail->>'IPIN' as iPin,
+ tl.status,additionalDetail->>'IPIN' as iPin,
- additionalDetail->>'mobileNo' as mobileNp
+ additionalDetail->>'mobileNo' as mobileNpCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| select | |
| tl.applicationnumber, | |
| tld.additionalDetail::text, | |
| tl.status,additionalDetail->>'IPIN' as iPin, | |
| additionalDetail->>'APPID' as appId, | |
| additionalDetail->>'mobileNo' as mobileNp | |
| from eg_tl_tradelicense tl | |
| select | |
| tl.applicationnumber, | |
| tld.additionalDetail::text, | |
| tl.status,additionalDetail->>'IPIN' as iPin, | |
| additionalDetail->>'APPID' as appId, | |
| additionalDetail->>'mobileNo' as mobileNp | |
| from eg_tl_tradelicense tl |
Tools
yamllint
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
| - name: searchGisMap | ||
| query: | ||
| baseQuery: | | ||
| select array_to_json(array_agg(row_to_json(data))) from ( | ||
| with units as | ||
| ( | ||
| select | ||
| propertyuuid, | ||
| string_agg(occupancytype,',') as occupancy, | ||
| sum(builtuparea) as builtup_area | ||
| from report_units | ||
| where propertyuuid in (select pt_uuid from report_properties rp $where) | ||
| group by propertyuuid | ||
| ) | ||
| select | ||
| surveyid as plot_map_id, | ||
| upper(split_part(rp.tenantid,'.',2)) as town, | ||
| split_part(replace(surveyid,upper(split_part(rp.tenantid,'.',2)),''),'-',2) as sector, | ||
| split_part(surveyid,'-',2) as subsector, | ||
| split_part(surveyid,'-',2) as plot, | ||
| split_part(rp.tenantid,'.',2) as city, | ||
| rp.propertyid as property_id, | ||
| oldpropertyid as oldpropertyid, | ||
| 'uidno' as uid_no, | ||
| blockname as wardno, | ||
| builtup_area as builtup_area, | ||
| plotsize as land_area, | ||
| 'area' as area, | ||
| nooffloors as no_of_floors, | ||
| propertyusagetype as usage_category, | ||
| occupancy as occupancy, | ||
| ownershipcategory as ownership_category, | ||
| assessmentyears as financial_year, | ||
| rpay.amoutpaid as amunt_paid, | ||
| rpay.receiptdate as date_of_payment | ||
| from report_properties rp | ||
| inner join units ru on rp.pt_uuid=ru.propertyuuid | ||
| inner join report_assessments ra on (ra.propertyid=rp.propertyid and ra.demandstatus!='CANCELLED') | ||
| inner join report_payments rpay on (rpay.propertyid=rp.propertyid and rpay.amoutpaid=ra.amount) | ||
| $where) data | ||
| groupBy: | ||
| orderBy: | ||
| searchParams: | ||
| condition: AND | ||
| params: | ||
| - name: surveyid | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.plot_map_id | ||
| operator: = | ||
| - name: rp.tenantid | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.town | ||
| operator: = | ||
|
|
There was a problem hiding this comment.
Potential Typo in SQL Query and Verification of Search Parameters and Output Formats
The searchGisMap function is well-defined, but there is a potential typo in the SQL query:
- SQL Query: The join condition
inner join units ru on rp.pt_uuid=ru.propertyuuilikely contains a typo. It should berp.pt_uuid=ru.propertyuuid.
The search parameters and output formats are correctly structured and mapped.
-
Search Parameters:
surveyidis mandatory and mapped to$.searchCriteria.plot_map_id.- Other parameters are correctly defined in the context.
-
Output Formats:
jsonFormatis correctly structured with{"ResponseInfo": {}}.outJsonPathis set to$.data.responseInfoPathis set to$.ResponseInfo.
Please address the potential typo in the SQL query.
- inner join units ru on rp.pt_uuid=ru.propertyuui
+ inner join units ru on rp.pt_uuid=ru.propertyuuidCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: searchGisMap | |
| query: | |
| baseQuery: | | |
| select array_to_json(array_agg(row_to_json(data))) from ( | |
| with units as | |
| ( | |
| select | |
| propertyuuid, | |
| string_agg(occupancytype,',') as occupancy, | |
| sum(builtuparea) as builtup_area | |
| from report_units | |
| where propertyuuid in (select pt_uuid from report_properties rp $where) | |
| group by propertyuuid | |
| ) | |
| select | |
| surveyid as plot_map_id, | |
| upper(split_part(rp.tenantid,'.',2)) as town, | |
| split_part(replace(surveyid,upper(split_part(rp.tenantid,'.',2)),''),'-',2) as sector, | |
| split_part(surveyid,'-',2) as subsector, | |
| split_part(surveyid,'-',2) as plot, | |
| split_part(rp.tenantid,'.',2) as city, | |
| rp.propertyid as property_id, | |
| oldpropertyid as oldpropertyid, | |
| 'uidno' as uid_no, | |
| blockname as wardno, | |
| builtup_area as builtup_area, | |
| plotsize as land_area, | |
| 'area' as area, | |
| nooffloors as no_of_floors, | |
| propertyusagetype as usage_category, | |
| occupancy as occupancy, | |
| ownershipcategory as ownership_category, | |
| assessmentyears as financial_year, | |
| rpay.amoutpaid as amunt_paid, | |
| rpay.receiptdate as date_of_payment | |
| from report_properties rp | |
| inner join units ru on rp.pt_uuid=ru.propertyuuid | |
| inner join report_assessments ra on (ra.propertyid=rp.propertyid and ra.demandstatus!='CANCELLED') | |
| inner join report_payments rpay on (rpay.propertyid=rp.propertyid and rpay.amoutpaid=ra.amount) | |
| $where) data | |
| groupBy: | |
| orderBy: | |
| searchParams: | |
| condition: AND | |
| params: | |
| - name: surveyid | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.plot_map_id | |
| operator: = | |
| - name: rp.tenantid | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.town | |
| operator: = | |
| - name: searchGisMap | |
| query: | |
| baseQuery: | | |
| select array_to_json(array_agg(row_to_json(data))) from ( | |
| with units as | |
| ( | |
| select | |
| propertyuuid, | |
| string_agg(occupancytype,',') as occupancy, | |
| sum(builtuparea) as builtup_area | |
| from report_units | |
| where propertyuuid in (select pt_uuid from report_properties rp $where) | |
| group by propertyuuid | |
| ) | |
| select | |
| surveyid as plot_map_id, | |
| upper(split_part(rp.tenantid,'.',2)) as town, | |
| split_part(replace(surveyid,upper(split_part(rp.tenantid,'.',2)),''),'-',2) as sector, | |
| split_part(surveyid,'-',2) as subsector, | |
| split_part(surveyid,'-',2) as plot, | |
| split_part(rp.tenantid,'.',2) as city, | |
| rp.propertyid as property_id, | |
| oldpropertyid as oldpropertyid, | |
| 'uidno' as uid_no, | |
| blockname as wardno, | |
| builtup_area as builtup_area, | |
| plotsize as land_area, | |
| 'area' as area, | |
| nooffloors as no_of_floors, | |
| propertyusagetype as usage_category, | |
| occupancy as occupancy, | |
| ownershipcategory as ownership_category, | |
| assessmentyears as financial_year, | |
| rpay.amoutpaid as amunt_paid, | |
| rpay.receiptdate as date_of_payment | |
| from report_properties rp | |
| inner join units ru on rp.pt_uuid=ru.propertyuuid | |
| inner join report_assessments ra on (ra.propertyid=rp.propertyid and ra.demandstatus!='CANCELLED') | |
| inner join report_payments rpay on (rpay.propertyid=rp.propertyid and rpay.amoutpaid=ra.amount) | |
| $where) data | |
| groupBy: | |
| orderBy: | |
| searchParams: | |
| condition: AND | |
| params: | |
| - name: surveyid | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.plot_map_id | |
| operator: = | |
| - name: rp.tenantid | |
| isMandatory: false | |
| jsonPath: $.searchCriteria.town | |
| operator: = | |
Tools
yamllint
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 214-214: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Actionable comments posted: 5
Outside diff range, codebase verification and nitpick comments (1)
configs/egov-searcher/rainmaker-pt-gissearch.yml (1)
164-200: Verify the correctness of the SQL query.The base query includes new fields and joins. Ensure that the new fields and joins are correct and necessary. Additionally, there is a potential typo in the SQL query:
rpay.amoutpaidshould likely berpay.amountpaid.Please verify the joins and fields for correctness.
- Verify the field
rpay.amoutpaid.- Verify the joins and fields in the SQL query.
Analysis chain
Verify the correctness of the SQL query.
The base query includes new fields and joins. Ensure that the new fields and joins are correct and necessary.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the SQL query in `searchGisMap`. # Test: Check the SQL query syntax for common SQL keywords and structure issues. rg --type yaml 'baseQuery:.*select' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Extract a broader context of the SQL query in `searchGisMap` to verify its correctness. # Test: Search for the SQL query and extract 40 lines of context to review the query structure and joins. rg --type yaml 'select array_to_json(array_agg(row_to_json(data))) from (' -A 40 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 296
Script:
#!/bin/bash # Description: Extract a broader context of the SQL query in `searchGisMap` to verify its correctness. # Test: Search for the SQL query and extract 40 lines of context to review the query structure and joins. rg --type yaml 'select array_to_json' -A 40 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 6668
Tools
yamllint
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- configs/egov-searcher/rainmaker-pt-gissearch.yml (1 hunks)
Additional context used
yamllint
configs/egov-searcher/rainmaker-pt-gissearch.yml
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
[error] 75-75: trailing spaces
(trailing-spaces)
[error] 113-113: trailing spaces
(trailing-spaces)
[error] 129-129: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
[error] 153-153: trailing spaces
(trailing-spaces)
[error] 158-158: trailing spaces
(trailing-spaces)
[error] 159-159: trailing spaces
(trailing-spaces)
[error] 160-160: trailing spaces
(trailing-spaces)
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 176-176: trailing spaces
(trailing-spaces)
[error] 214-214: trailing spaces
(trailing-spaces)
[error] 215-215: trailing spaces
(trailing-spaces)
Additional comments not posted (5)
configs/egov-searcher/rainmaker-pt-gissearch.yml (5)
85-115: Verify the correctness of the SQL query.The base query includes new fields and joins. Ensure that the new fields and joins are correct and necessary.
Tools
yamllint
[error] 113-113: trailing spaces
(trailing-spaces)
139-143: Verify the correctness of the SQL query.The base query includes new fields and joins. Ensure that the new fields and joins are correct and necessary.
Verification successful
Let's refine the search pattern to ensure we capture the relevant SQL query and verify the correctness of the SQL syntax.
Verify the correctness of the SQL query.
The SQL query in the
GetTenantConfigsection appears to be correct. It selects specific columns (id,tenantid,locality,issurveyidmandatory) from theeg_tenant_configtable and uses$whereas a placeholder for conditions. There are no complex joins or additional fields that need further verification.
- The query structure is correct.
- The fields selected are appropriate and necessary for the intended purpose.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the SQL query in `GetTenantConfig`. # Test: Check the SQL query syntax for common SQL keywords and structure issues. rg --type yaml 'baseQuery:.*select' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Verify the correctness of the SQL query in `GetTenantConfig`. # Test: Check the SQL query syntax for common SQL keywords and structure issues. rg --type yaml 'select.*from' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 5899
Tools
yamllint
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 141-141: trailing spaces
(trailing-spaces)
33-48: Verify the completeness of the search parameters.The search parameters have been updated to include new and modified parameters. Ensure that all necessary parameters are included and correctly defined.
Verification successful
Verify the completeness of the search parameters.
The search parameters in the
configs/egov-searcher/rainmaker-pt-gissearch.ymlfile have been reviewed. The parameters includepd.receiptdate,pt.tenantid,bn.blockname,tenantid,rp.tenantid, andsurveyid. Each parameter is correctly defined with attributes likeisMandatory,jsonPath, andoperator.
- The parameters appear complete and correctly defined across all
searchParamssections.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the completeness of the search parameters in `searchNewTaxPayments`. # Test: Verify the search parameters are correctly defined. rg --type yaml 'searchParams:' -A 10 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 1298
Script:
#!/bin/bash # Description: Verify the completeness of the search parameters in `searchNewTaxPayments`. # Test: Verify the search parameters are correctly defined with extended context. rg --type yaml 'searchParams:' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 2462
60-68: Verify the correctness of the SQL query.The base query includes new fields and joins. Ensure that the new fields and joins are correct and necessary.
Tools
yamllint
[error] 61-61: trailing spaces
(trailing-spaces)
[error] 66-66: trailing spaces
(trailing-spaces)
[error] 67-67: trailing spaces
(trailing-spaces)
12-21: Verify the correctness of the SQL query.The base query has been expanded to include new fields and joins. Ensure that the new fields and joins are correct and necessary.
Verification successful
Verify the correctness of the SQL query.
The extracted SQL query and search parameters appear to be correctly structured and necessary for the functionality. The fields and joins are valid and correctly implemented.
SQL Query:
select array_to_json(array_agg(row_to_json(data))) from ( select concat(pt.propertyid , '/' , pt.surveyid) as primarykey, pt.oldpropertyid as oldpropertyid, pt.surveyid as surveyid, pd.amountpaid as amount, getfinancialyearforgis(pd.billid) as financialyear, bn.blockname, pt.tenantid as tenantid, pd.receiptnumber as receiptnumber, to_char(to_timestamp(cast(pd.receiptdate/1000 as bigint))::date , 'dd/mm/yyyy') as receiptdate, pt.landarea as plotarea from egcl_paymentdetail AS pd INNER JOIN egcl_bill on pd.billid=egcl_bill.id INNER JOIN eg_pt_property AS pt ON pt.propertyid = egcl_bill.consumercode AND ((pt.oldpropertyid IS NOT NULL AND pt.oldpropertyid != '') OR pt.surveyid is not null) INNER JOIN eg_pt_address As ad ON ad.propertyid=pt.id and ad.lastmodifiedtime in (select max(lastmodifiedtime) from eg_pt_address where propertyid=pt.id) INNER JOIN eg_bndry_mohalla As bn ON ad.locality=bn.localitycode and ad.tenantid=bn.tenantid $where) dataSearch Parameters:
searchParams: condition: AND params: - name: pd.receiptdate isMandatory: false jsonPath: $.searchCriteria.fromDate operator: GE - name: pd.receiptdate isMandatory: false jsonPath: $.searchCriteria.toDate operator: LE - name: pt.tenantid isMandatory: true jsonPath: $.searchCriteria.tenantId operator: = - name: bn.blockname isMandatory: false jsonPath: $.searchCriteria.blockcode operator: =The SQL query and search parameters are correctly structured and necessary for the functionality.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the SQL query in `searchNewTaxPayments`. # Test: Check the SQL query syntax for common SQL keywords and structure issues. rg --type yaml 'baseQuery:.*select' -A 20 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 92
Script:
#!/bin/bash # Description: Verify the correctness of the SQL query in `searchNewTaxPayments`. # Test: Locate the SQL query section and extract a larger context to ensure completeness. rg --type yaml 'select' -A 50 configs/egov-searcher/rainmaker-pt-gissearch.ymlLength of output: 7419
| condition: AND | ||
| params: | ||
|
|
There was a problem hiding this comment.
Complete the searchParams definition.
The searchParams section is defined but lacks specific parameters. This might affect the functionality of the search.
searchParams:
condition: AND
params:
- name: tl.applicationnumber
isMandatory: true
jsonPath: $.searchCriteria.applicationNumber
operator: =
- name: tld.additionalDetail
isMandatory: false
jsonPath: $.searchCriteria.additionalDetail
operator: LIKE
- name: tl.status
isMandatory: false
jsonPath: $.searchCriteria.status
operator: =
- name: additionalDetail->>'IPIN'
isMandatory: false
jsonPath: $.searchCriteria.iPin
operator: =
- name: additionalDetail->>'APPID'
isMandatory: false
jsonPath: $.searchCriteria.appId
operator: =
- name: additionalDetail->>'mobileNo'
isMandatory: false
jsonPath: $.searchCriteria.mobileNo
operator: =| - name: pd.receiptdate | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.fromDate | ||
| operator: GE | ||
| - name: pd.receiptdate | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.toDate | ||
| operator: LE |
There was a problem hiding this comment.
Complete the searchParams definition.
The searchParams section is defined but lacks specific parameters. This might affect the functionality of the search.
searchParams:
condition: AND
params:
- name: pd.receiptdate
isMandatory: false
jsonPath: $.searchCriteria.fromDate
operator: GE
- name: pd.receiptdate
isMandatory: false
jsonPath: $.searchCriteria.toDate
operator: LE| - name: tenantid | ||
| isMandatory: true | ||
| jsonPath: $.searchCriteria.tenantId | ||
| operator: = |
There was a problem hiding this comment.
Complete the searchParams definition.
The searchParams section is defined but lacks specific parameters. This might affect the functionality of the search.
searchParams:
condition: AND
params:
- name: tenantid
isMandatory: true
jsonPath: $.searchCriteria.tenantId
operator: =| condition: AND | ||
| params: | ||
| - name: rp.tenantid | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.town | ||
| operator: = | ||
| - name: surveyid | ||
| isMandatory: false | ||
| jsonPath: $.searchCriteria.plot_map_id | ||
| operator: = | ||
|
|
There was a problem hiding this comment.
Complete the searchParams definition.
The searchParams section is defined but lacks specific parameters. This might affect the functionality of the search.
searchParams:
condition: AND
params:
- name: rp.tenantid
isMandatory: false
jsonPath: $.searchCriteria.town
operator: =
- name: surveyid
isMandatory: false
jsonPath: $.searchCriteria.plot_map_id
operator: =Tools
yamllint
[error] 214-214: trailing spaces
(trailing-spaces)
| rpay.amoutpaid as amunt_paid, | ||
| rpay.receiptdate as date_of_payment | ||
| from report_properties rp | ||
| inner join units ru on rp.pt_uuid=ru.propertyuuid |
There was a problem hiding this comment.
Fix the potential typo in the SQL query.
The join condition inner join units ru on rp.pt_uuid=ru.propertyuui likely contains a typo. It should be rp.pt_uuid=ru.propertyuuid.
- inner join units ru on rp.pt_uuid=ru.propertyuui
+ inner join units ru on rp.pt_uuid=ru.propertyuuidCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| inner join units ru on rp.pt_uuid=ru.propertyuuid | |
| inner join units ru on rp.pt_uuid=ru.propertyuuid |
Summary by CodeRabbit
New Features
start.shscript to set Java options and enable debugging for Maven builds.Enhancements
rainmaker-pt-gissearch.ymlconfiguration file with significant changes to theSearchDefinitionssection, including new fields, modified parameters, and new JSON output formats for various search operations.Refactor
buildPipelineusing a configuration file.