This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Develop #723
Develop #723
Changes from 45 commits
9fccab3
fe8e3eb
661bdd1
0abfa5f
bf2a595
0c0c245
19b6338
a62d382
b035dfc
f7481ab
96d10b0
d26e47f
47365d2
b505ad3
c3f4eb4
5f82710
2fdd4cc
34895a1
e559f5c
c725190
a8fa9ca
2a7ef07
925aca8
b05c681
6deccde
e18dfbf
4c70d67
1d89129
c28c489
61f18a4
5cd2bf7
19f0691
0660b5d
fbdcdf7
dcb27c2
79e982d
007b764
3d63324
0fde276
6365201
18bdefc
45822c3
7f6db5b
afd1d20
a893b59
d1de16c
ed7239b
3ca6518
f046b45
fdd4ec9
9fdf83c
18293e9
36dc83a
3540e03
0199429
d75aa6f
1ecd146
6698791
26372ee
4a9022a
c930a71
e5506d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of
getBillingCycleMonthCountCurrent
method is a good approach to encapsulate the logic for calculating billing cycle months. However, consider the following points for improvement:months
and the condition for clearingmonths
, would improve readability and maintainability.billYear
values. Consider adding checks or try-catch blocks to handle unexpected inputs gracefully.Enhance code clarity with comments explaining complex logic and consider adding error handling for more robustness. Ensure consistency in date handling across the application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an issue in the
dispose
method where it adds the_numberFocus
listener instead of removing it. This can lead to memory leaks and unintended behavior. The correct approach is to remove the listener when the widget is disposed of.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
getPastMonthUntilFinancialYTDMonthCount
method correctly calculates the list ofDatePeriod
objects for months considering a specific month count. Consider adding comments to explain the logic, especially for complex parts, to improve maintainability.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in MDMS V2 we are not using location-service to get location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method
sendDownloadBillSMSNotification
has been updated to include a new parametertotalamount
, which is used to conditionally send SMS notifications based on the bill amount. This is a logical improvement for user experience, ensuring that notifications are meaningful. However, ensure that:totalamount
parameter is accurately calculated and represents the total bill amount correctly.sendDownloadBillSMSNotification
are updated to pass thetotalamount
parameter.Additionally, consider handling potential exceptions or errors that might occur during the SMS sending process to ensure the application's robustness.