Merge pull request #858 from egovernments/ISTE-259

ISTE-259: Added chnage to not allow WS_TIME_PEnalty with Zero
egovernments · Jul 15, 2024 · 0c33d77 · 0c33d77
2 parents 3595034 + e20c0d0
commit 0c33d77
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/...al-services/ws-calculator/src/main/java/org/egov/wscalculation/service/DemandService.java b/...al-services/ws-calculator/src/main/java/org/egov/wscalculation/service/DemandService.java
@@ -1544,13 +1544,15 @@ public List<DemandDetail> addTimePenalty(Integer rate, String type, String SubTy
 					BigDecimal tax = netPayableAmountWithouttax.multiply(taxPercentage.divide(WSCalculationConstant.HUNDRED));
 					//round off to next higest number
 					tax = roundOffTax(tax);
-					DemandDetail timeDemandDetail = DemandDetail.builder().demandId(demand.getId())
-							.taxHeadMasterCode(WSCalculationConstant.WS_TIME_PENALTY)
-							.taxAmount(tax)
-							.collectionAmount(BigDecimal.ZERO)
-							.tenantId(demand.getTenantId()).build();
-
-					demandDetailList.add(timeDemandDetail);
+					if(tax.compareTo(BigDecimal.ZERO) > 0) {
+						DemandDetail timeDemandDetail = DemandDetail.builder().demandId(demand.getId())
+								.taxHeadMasterCode(WSCalculationConstant.WS_TIME_PENALTY)
+								.taxAmount(tax)
+								.collectionAmount(BigDecimal.ZERO)
+								.tenantId(demand.getTenantId()).build();
+
+						demandDetailList.add(timeDemandDetail);
+					}
 				}
 			}
 		}