HCMPRE-203: updated changes as per code review comments

egovernments · Aug 23, 2024 · 69387ea · 69387ea
1 parent 51a6ff8
commit 69387ea
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...services/transformer/src/main/java/org/egov/transformer/consumer/ProjectTaskConsumer.java b/...services/transformer/src/main/java/org/egov/transformer/consumer/ProjectTaskConsumer.java
@@ -62,7 +62,7 @@ public void consumeUserAction(ConsumerRecord<String, Object> payload,
             );
             userActionLocationCaptureAggregationService.processUserActionLocationCapture(payloadList);
         } catch (Exception exception) {
-            log.error("error in project user action bulk consumer", exception);
+            log.error("Error in project user action bulk consumer", exception);
         }
     }
 }
diff --git a/...c/main/java/org/egov/transformer/service/UserActionLocationCaptureAggregationService.java b/...c/main/java/org/egov/transformer/service/UserActionLocationCaptureAggregationService.java
@@ -14,6 +14,7 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import lombok.extern.slf4j.Slf4j;
 import org.egov.common.models.project.useraction.UserAction;
+import org.egov.tracer.model.CustomException;
 import org.egov.transformer.aggregator.config.ServiceConfiguration;
 import org.egov.transformer.aggregator.models.ElasticsearchHit;
 import org.egov.transformer.aggregator.models.UserActionCompositeKey;
@@ -202,7 +203,7 @@ public JsonNode buildGeoJson(List<UserAction> userActionList) {
             return objectMapper.readTree(jsonString);
         } catch (Exception e) {
             log.error("Failed to build GeoJSON: ", e);
-            return null; // Handle exception properly in production code
+            throw new CustomException("Error building GeoJSON from user actions", e.getMessage());
         }
     }