integration with the generate and create api #314

Bhavya-egov · 2024-04-17T07:52:18Z

Summary by CodeRabbit

New Features
- Introduced a new React component for data file management (UploadData).
- Added new hooks for campaign ID generation and resource data management.
- Enhanced campaign configuration with new steps and fields.
- Updated the version of @egovernments/digit-ui-css to 1.0.14-campaign.
Enhancements
- Improved visual styling for file upload components.
- Updated proxy paths for more efficient data handling.
Bug Fixes
- Corrected import paths and component references across various modules.
- Updated package.json with the ajv package dependency.

…tend into HLM-5110

coderabbitai · 2024-04-17T07:52:30Z

Walkthrough

The update enriches the micro-ui framework with new features like a data upload management React component, a custom hook for generating campaign IDs, and enhanced logic in the SetupCampaign page for handling various campaign management scenarios.

Changes

File Path	Change Summary
`.../components/UploadData.js`, `.../hooks/useGenerateIdCampaign.js`, `.../pages/employee/SetupCampaign.js`	Introduced a React component for data uploads, a custom hook for generating campaign IDs, and updated logic in the `SetupCampaign` page for improved campaign management.
`.../hooks/useResourceData.js`	Added new function `useResourceData` from `Digit.Hooks.campaign`.
`.../public/index.html`	Updated `@egovernments/digit-ui-css` version from `1.0.13-campaign` to `1.0.14-campaign`.
`.../package.json`	Added `ajv` package as a dependency with version `^8.12.0`.

Poem

🐇🌟
A hop and a skip in the code, quite neat,
With changes so swift, and none too discreet.
Upgraded with style, and hooks that entice,
Now smoother than ever, just like ice.
Cheers to the devs, with each line they compose,
In the world of code, where creativity flows! 🎉🐰

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e1a1b68 and 54355b0.

Files selected for processing (3)

micro-ui/web/micro-ui-internals/example/public/index.html (1 hunks)
micro-ui/web/micro-ui-internals/package.json (2 hunks)
micro-ui/web/public/index.html (1 hunks)

Files skipped from review as they are similar to previous changes (3)

micro-ui/web/micro-ui-internals/example/public/index.html
micro-ui/web/micro-ui-internals/package.json
micro-ui/web/public/index.html

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

coderabbitai · 2024-04-17T07:59:14Z

micro-ui/web/micro-ui-internals/example/public/index.html

@@ -16,7 +16,7 @@
  /> -->
  <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" />
  <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" />
-  <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected].13-campaign/dist/index.css" />
+  <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected].14-campaign/dist/index.css" />


Tip
Codebase Verification

Verification Result: Issue with CSS Version Link

The verification process aimed to confirm the accessibility of the updated version 1.0.14-campaign of @egovernments/digit-ui-css at the specified URL. The script executed returned a 404 HTTP status code, indicating that the resource is not found at the provided URL.

Action Required:

Please check the version number and the URL for any typographical errors.

Verify if the version 1.0.14-campaign is correctly published and available on the CDN.

Consider reverting to a previous version if the current one is not yet deployed.

Analysis chain

Confirm that the updated version 1.0.14-campaign of @egovernments/digit-ui-css is correctly deployed and accessible at the specified URL.

Scripts Executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash # Check if the specified CSS version is accessible. curl -o /dev/null -s -w "%{http_code}\n" https://unpkg.com/@egovernments/[email protected]/dist/index.css

Length of output: 122

jagankumar-egov · 2024-04-17T08:19:51Z

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/hooks/useResourceData.js

+        body: {
+            "ResourceDetails": {
+                "type": data?.uploadFacility?.[0]?.type,
+                "hierarchyType": "ADMIN",


@Bhavya-egov make this also as a param

jagankumar-egov · 2024-04-17T08:31:37Z

.../web/micro-ui-internals/packages/modules/campaign-manager/src/hooks/useGenerateIdCampaign.js

+    url: `/project-factory/v1/data/_generate`,
+    changeQueryName :   `${type}-${hierarchyType}`,
+    params: {
+      tenantId: "mz",


const tenantId = Digit.ULBService.getCurrentTenantId();
better to use this hook instead of directly setting value as mz

jagankumar-egov · 2024-04-17T08:58:37Z

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js

+    const filesArray = [fileStoreIds?.[0]?.fileStoreId];
+    const { data: { fileStoreIds: fileUrl } = {} } = await Digit.UploadServices.Filefetch(filesArray, tenantId);
+    const fileData = fileUrl.map((i) => {
+      const t = i?.url?.split("/");


rename , dont use t or dd give proper names

jagankumar-egov · 2024-04-17T08:58:59Z

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/UploadData.js

+          tenantId: tenantId,
+          type: type,
+          forceUpdate: false,
+          hierarchyType: "ADMIN",


hirarchy type should only be present in 1 file

Bhavya-egov added 3 commits April 17, 2024 13:16

HLM-5110 integrated facility with generate api

f0c0b12

Merge branch 'campaign' of https://github.com/egovernments/DIGIT-Fron…

32a187a

…tend into HLM-5110

updated css version

6dc5eb0

Bhavya-egov requested a review from nabeelmd-eGov as a code owner April 17, 2024 07:52

coderabbitai bot requested changes Apr 17, 2024

View reviewed changes

jagankumar-egov reviewed Apr 17, 2024

View reviewed changes

made hierarchy type as generic

211b3c2

jagankumar-egov reviewed Apr 17, 2024

View reviewed changes

Bhavya-egov added 2 commits April 17, 2024 14:55

changed variable names

8fbcede

changes in hierarchy type

e1a1b68

jagankumar-egov approved these changes Apr 17, 2024

View reviewed changes

Merge branch 'campaign' into HLM-5110

54355b0

jagankumar-egov merged commit 0be2985 into campaign Apr 17, 2024
2 of 3 checks passed

jagankumar-egov deleted the HLM-5110 branch April 17, 2024 11:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

integration with the generate and create api #314

integration with the generate and create api #314

Bhavya-egov commented Apr 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 17, 2024 •

edited

Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot Apr 17, 2024

jagankumar-egov Apr 17, 2024

jagankumar-egov Apr 17, 2024

jagankumar-egov Apr 17, 2024

jagankumar-egov Apr 17, 2024

integration with the generate and create api #314

integration with the generate and create api #314

Conversation

Bhavya-egov commented Apr 17, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Apr 17, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Apr 17, 2024

Choose a reason for hiding this comment

Verification Result: Issue with CSS Version Link

jagankumar-egov Apr 17, 2024

Choose a reason for hiding this comment

jagankumar-egov Apr 17, 2024

Choose a reason for hiding this comment

jagankumar-egov Apr 17, 2024

Choose a reason for hiding this comment

jagankumar-egov Apr 17, 2024

Choose a reason for hiding this comment

Bhavya-egov commented Apr 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 17, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)