-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added latest stepper and toast #274
Conversation
WalkthroughThe recent updates to the Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (8)
- micro-ui/web/micro-ui-internals/example/package.json (1 hunks)
- micro-ui/web/micro-ui-internals/example/public/index.html (1 hunks)
- micro-ui/web/micro-ui-internals/packages/css/README.md (1 hunks)
- micro-ui/web/micro-ui-internals/packages/css/package.json (1 hunks)
- micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/campaignCycle.scss (1 hunks)
- micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/package.json (1 hunks)
- micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/SetupCampaign.js (2 hunks)
- micro-ui/web/public/index.html (1 hunks)
Files skipped from review due to trivial changes (3)
- micro-ui/web/micro-ui-internals/example/package.json
- micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/campaignCycle.scss
- micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/package.json
Additional Context Used
Path-based Instructions (1)
micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/SetupCampaign.js (1)
Pattern
**/*.js
: check
Additional comments not posted (13)
micro-ui/web/micro-ui-internals/packages/css/README.md (6)
Line range hint
3-3
: Consider updating the placeholder comment to reflect the current state or remove it if it's no longer needed.
Line range hint
20-20
: Consider adding a comma after "After adding the dependency" for better readability.
45-45
: Ensure the changelog entries for versions 1.0.7-campaign and 1.0.5-campaign accurately describe the changes made. It's good practice to provide more detail about the fixes for better clarity.
Line range hint
55-55
: Check the spelling of contributor names to ensure accuracy.
Line range hint
57-57
: Remove the duplicated phrase "DIGIT Frontend" to improve readability.
Line range hint
62-62
: Verify the spelling of contributor names for correctness.micro-ui/web/micro-ui-internals/packages/css/package.json (1)
3-3
: Version update from "1.0.6-campaign" to "1.0.7-campaign" is noted. Ensure that this version bump aligns with the changes documented in the README.md and that all dependent projects are compatible with this new version.micro-ui/web/micro-ui-internals/example/public/index.html (1)
18-19
: Updated CSS file versions to1.8.2-coreui.3
and1.0.7-campaign
. Confirm that these updates are correctly reflected across all relevant files and that there are no compatibility issues with these new versions.micro-ui/web/public/index.html (1)
13-14
: Updated CSS file versions to1.0.7-campaign
and1.8.2-coreui.3
. Ensure these version updates are consistent across all instances where they are referenced and check for any compatibility issues.micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/SetupCampaign.js (4)
1-1
: ReplacedLoader
andToast
components from@egovernments/digit-ui-react-components
withToast
from@egovernments/digit-ui-components
. Ensure that the newToast
component is integrated correctly and that all its instances are updated accordingly.
8-8
: Introduced a newStepper
component from@egovernments/digit-ui-components
. Verify that theStepper
component is correctly implemented and that it enhances the user experience as intended.
427-439
: TheStepper
component is configured with custom steps for the campaign setup process. Ensure that these steps are correctly mapped to the corresponding forms and actions in the setup process. It's crucial to verify that thecurrentStep
andonStepClick
handlers are functioning as expected to provide a smooth user experience.
427-439
: Consider adding a brief comment explaining the purpose and structure of the custom steps array for theStepper
component. This will improve code readability and maintainability, especially for new developers or when revisiting this code in the future.
No description provided.