Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added latest stepper and toast #274

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Added latest stepper and toast #274

merged 4 commits into from
Apr 8, 2024

Conversation

nabeelmd-eGov
Copy link
Contributor

No description provided.

Copy link
Contributor

coderabbitai bot commented Apr 8, 2024

Walkthrough

The recent updates to the micro-ui project involve minor version upgrades for dependencies, UI component replacements, and CSS adjustments. These changes aim to enhance the user interface, improve the application's styling consistency, and update the underlying libraries to newer versions, thereby potentially addressing compatibility and stability issues.

Changes

Files Change Summary
.../micro-ui-internals/example/package.json, .../campaign-manager/package.json Updated @egovernments/digit-ui-components from 0.0.1-beta.3 to 0.0.1-beta.4.
.../micro-ui-internals/example/public/index.html, .../web/public/index.html Updated CSS versions for @egovernments/digit-ui-css to 1.8.2-coreui.3 and 1.0.7-campaign.
.../micro-ui-internals/packages/css/README.md, .../packages/css/package.json Added CSS fixes and updated version to 1.0.7-campaign.
.../micro-ui-internals/packages/css/src/pages/employee/campaignCycle.scss Added !important to align-items in .label-field-pair.
.../micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/SetupCampaign.js Replaced UI components and introduced Stepper for campaign setup process.

Possibly related issues

🐰✨
A hop, a skip, in the digital realm, we play,
Updating, upgrading, making UIs bright as day.
With components so sleek, and CSS so chic,
We fix, we tweak, for the performance we seek.
In the world of code, where rabbits dare to dream,
We craft with love, a digital stream. 🌟🚀
🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 737f873 and a5dba19.
Files selected for processing (8)
  • micro-ui/web/micro-ui-internals/example/package.json (1 hunks)
  • micro-ui/web/micro-ui-internals/example/public/index.html (1 hunks)
  • micro-ui/web/micro-ui-internals/packages/css/README.md (1 hunks)
  • micro-ui/web/micro-ui-internals/packages/css/package.json (1 hunks)
  • micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/campaignCycle.scss (1 hunks)
  • micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/package.json (1 hunks)
  • micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/SetupCampaign.js (2 hunks)
  • micro-ui/web/public/index.html (1 hunks)
Files skipped from review due to trivial changes (3)
  • micro-ui/web/micro-ui-internals/example/package.json
  • micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/campaignCycle.scss
  • micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/package.json
Additional Context Used
Path-based Instructions (1)
micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/SetupCampaign.js (1)

Pattern **/*.js: check

Additional comments not posted (13)
micro-ui/web/micro-ui-internals/packages/css/README.md (6)

Line range hint 3-3: Consider updating the placeholder comment to reflect the current state or remove it if it's no longer needed.


Line range hint 20-20: Consider adding a comma after "After adding the dependency" for better readability.


45-45: Ensure the changelog entries for versions 1.0.7-campaign and 1.0.5-campaign accurately describe the changes made. It's good practice to provide more detail about the fixes for better clarity.


Line range hint 55-55: Check the spelling of contributor names to ensure accuracy.


Line range hint 57-57: Remove the duplicated phrase "DIGIT Frontend" to improve readability.


Line range hint 62-62: Verify the spelling of contributor names for correctness.

micro-ui/web/micro-ui-internals/packages/css/package.json (1)

3-3: Version update from "1.0.6-campaign" to "1.0.7-campaign" is noted. Ensure that this version bump aligns with the changes documented in the README.md and that all dependent projects are compatible with this new version.

micro-ui/web/micro-ui-internals/example/public/index.html (1)

18-19: Updated CSS file versions to 1.8.2-coreui.3 and 1.0.7-campaign. Confirm that these updates are correctly reflected across all relevant files and that there are no compatibility issues with these new versions.

micro-ui/web/public/index.html (1)

13-14: Updated CSS file versions to 1.0.7-campaign and 1.8.2-coreui.3. Ensure these version updates are consistent across all instances where they are referenced and check for any compatibility issues.

micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/SetupCampaign.js (4)

1-1: Replaced Loader and Toast components from @egovernments/digit-ui-react-components with Toast from @egovernments/digit-ui-components. Ensure that the new Toast component is integrated correctly and that all its instances are updated accordingly.


8-8: Introduced a new Stepper component from @egovernments/digit-ui-components. Verify that the Stepper component is correctly implemented and that it enhances the user experience as intended.


427-439: The Stepper component is configured with custom steps for the campaign setup process. Ensure that these steps are correctly mapped to the corresponding forms and actions in the setup process. It's crucial to verify that the currentStep and onStepClick handlers are functioning as expected to provide a smooth user experience.


427-439: Consider adding a brief comment explaining the purpose and structure of the custom steps array for the Stepper component. This will improve code readability and maintainability, especially for new developers or when revisiting this code in the future.

@jagankumar-egov jagankumar-egov merged commit cf65f8a into campaign Apr 8, 2024
2 of 3 checks passed
@jagankumar-egov jagankumar-egov deleted the CSS_CAMPAIGN branch April 8, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants