Skip to content

Commit

Permalink
fix: fix github_api to consider commits without checks as passing
Browse files Browse the repository at this point in the history
  • Loading branch information
UsamaSadiq committed Jul 29, 2024
1 parent 1fa8a25 commit edcc78a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tubular/github_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -591,8 +591,11 @@ def _poll_commit(self, sha):
)
def _run():
result = self._is_commit_successful(sha)
if result[0] == False: # No Checks found against the Commit
# Returning any string other than '' will set the commit status to succeed.
# Returning 'success' to avoid breaking pipeline checks in case no actions are found
return ("success", None)
return (result[2], result[1])

return _run()

def poll_pull_request_test_status(self, pr_number):
Expand Down

0 comments on commit edcc78a

Please sign in to comment.