Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add sanctions models #6

Merged
merged 9 commits into from
Oct 19, 2023
Merged

feat: Add sanctions models #6

merged 9 commits into from
Oct 19, 2023

Conversation

julianajlk
Copy link
Member

@julianajlk julianajlk commented Oct 16, 2023 •
edited
Loading

REV-3627.

Adding sanctions directory, models, and some build related setup.

Creating the following models:

  • SanctionsCheckFailure
  • SanctionsFallbackMetadata
  • SanctionsFallbackData

Modifying the following models:

  • User

@julianajlk julianajlk force-pushed the julianajlk/REV-3627/sanctions-models branch 9 times, most recently from bb1769d to 806989b Compare October 18, 2023 13:41
@julianajlk julianajlk force-pushed the julianajlk/REV-3627/sanctions-models branch 9 times, most recently from 809dd88 to de6eaad Compare October 18, 2023 20:24
@julianajlk julianajlk force-pushed the julianajlk/REV-3627/sanctions-models branch from de6eaad to a893e78 Compare October 18, 2023 20:30
@julianajlk julianajlk force-pushed the julianajlk/REV-3627/sanctions-models branch from 4fc6651 to c1987a1 Compare October 18, 2023 20:43
@julianajlk julianajlk force-pushed the julianajlk/REV-3627/sanctions-models branch 2 times, most recently from 5e1cc92 to 4fc2beb Compare October 19, 2023 17:58
christopappas
christopappas approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@christopappas christopappas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could potentially add a comment or help_text for the metadata field to offer an example of the type of metadata you might add there

@julianajlk julianajlk force-pushed the julianajlk/REV-3627/sanctions-models branch 6 times, most recently from 504e9a1 to 011af82 Compare October 19, 2023 20:33
@julianajlk julianajlk force-pushed the julianajlk/REV-3627/sanctions-models branch from 011af82 to 6da910f Compare October 19, 2023 20:40
@julianajlk julianajlk merged commit 6e29482 into main Oct 19, 2023
6 checks passed
@julianajlk julianajlk deleted the julianajlk/REV-3627/sanctions-models branch October 19, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopappas christopappas christopappas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianajlk @christopappas