-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add fallback call and populate SDN data command #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianajlk
force-pushed
the
julianajlk/REV-3628/sdn-fallback
branch
13 times, most recently
from
November 6, 2023 21:07
f87f754
to
ae63ac5
Compare
julianajlk
force-pushed
the
julianajlk/REV-3628/sdn-fallback
branch
from
November 6, 2023 21:29
ae63ac5
to
c143f72
Compare
julianajlk
force-pushed
the
julianajlk/REV-3628/sdn-fallback
branch
from
November 6, 2023 21:57
c143f72
to
18b8f12
Compare
sanctions/apps/sanctions/management/commands/populate_sdn_fallback_data_and_metadata.py
Outdated
Show resolved
Hide resolved
sanctions/apps/sanctions/management/commands/populate_sdn_fallback_data_and_metadata.py
Outdated
Show resolved
Hide resolved
julianajlk
force-pushed
the
julianajlk/REV-3628/sdn-fallback
branch
from
November 8, 2023 19:24
60d4e70
to
f6bb17e
Compare
julianajlk
force-pushed
the
julianajlk/REV-3628/sdn-fallback
branch
from
November 9, 2023 16:59
85caa68
to
7f9caa7
Compare
christopappas
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor note about the test, but other wise looks good to me, we can give this a whirl
julianajlk
force-pushed
the
julianajlk/REV-3628/sdn-fallback
branch
from
November 9, 2023 21:00
d28adcb
to
2f963d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REV-3628.
Adding the call to the fallback if the US Treasury SDN API is down, as well as the command to populate SDN data into our fallback models.
Also renaming
SanctionsFallback
toSDNFallback
in the data and metadata models and functions.