Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add fallback call and populate SDN data command #12

Merged
merged 12 commits into from
Nov 9, 2023

Conversation

julianajlk
Copy link
Member

@julianajlk julianajlk commented Nov 3, 2023

REV-3628.

Adding the call to the fallback if the US Treasury SDN API is down, as well as the command to populate SDN data into our fallback models.
Also renaming SanctionsFallback to SDNFallback in the data and metadata models and functions.

@julianajlk julianajlk force-pushed the julianajlk/REV-3628/sdn-fallback branch 13 times, most recently from f87f754 to ae63ac5 Compare November 6, 2023 21:07
@julianajlk julianajlk force-pushed the julianajlk/REV-3628/sdn-fallback branch from ae63ac5 to c143f72 Compare November 6, 2023 21:29
@julianajlk julianajlk force-pushed the julianajlk/REV-3628/sdn-fallback branch from c143f72 to 18b8f12 Compare November 6, 2023 21:57
@julianajlk julianajlk force-pushed the julianajlk/REV-3628/sdn-fallback branch from 60d4e70 to f6bb17e Compare November 8, 2023 19:24
@julianajlk julianajlk force-pushed the julianajlk/REV-3628/sdn-fallback branch from 85caa68 to 7f9caa7 Compare November 9, 2023 16:59
Copy link
Contributor

@christopappas christopappas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor note about the test, but other wise looks good to me, we can give this a whirl

sanctions/apps/api/v1/tests/test_views.py Outdated Show resolved Hide resolved
sanctions/apps/sanctions/tests/test_models.py Outdated Show resolved Hide resolved
@julianajlk julianajlk force-pushed the julianajlk/REV-3628/sdn-fallback branch from d28adcb to 2f963d1 Compare November 9, 2023 21:00
@julianajlk julianajlk merged commit 34b2ad0 into main Nov 9, 2023
6 checks passed
@julianajlk julianajlk deleted the julianajlk/REV-3628/sdn-fallback branch November 9, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants