Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONIC-740: Added logs to note time for Commercetools calls #304

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

NoyanAziz
Copy link
Contributor

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

@NoyanAziz NoyanAziz changed the title temp: added logs to note time for ct calls SONIC-740: Added logs to note time for Commercetools calls Nov 29, 2024
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  commerce_coordinator/apps/commercetools
  clients.py
  pipeline.py
  commerce_coordinator/apps/commercetools/sub_messages
  tasks.py
  commerce_coordinator/apps/lms
  tasks.py
Project Total  

This report was generated by python-coverage-comment-action

@NoyanAziz NoyanAziz merged commit f436499 into main Dec 1, 2024
8 checks passed
@NoyanAziz NoyanAziz deleted the naziz1/SONIC-740/add-logs-for-ct-calls branch December 1, 2024 19:43
@NoyanAziz NoyanAziz restored the naziz1/SONIC-740/add-logs-for-ct-calls branch December 1, 2024 19:48
@NoyanAziz NoyanAziz deleted the naziz1/SONIC-740/add-logs-for-ct-calls branch December 1, 2024 19:48
NoyanAziz added a commit that referenced this pull request Dec 1, 2024
syedsajjadkazmii added a commit that referenced this pull request Dec 4, 2024
… mode (#302)

* chore: added logs to note time for commercetools calls (#304)

* feat: add tests

* fix: docs error

* fix: quality error

* fix: handle review comments

* fix: handle final review

---------

Co-authored-by: NoyanAziz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants