Cleanup

.gitignore

@@ -6,4 +6,3 @@
 /.idea
 /captures
 *.apk
-common/src/main/cpp/eduvpn_common.h

app/build.gradle

@@ -129,7 +129,7 @@ android {
             // See: https://github.com/google/dagger/issues/306#issuecomment-405525757
             option("-Xmaxerrs", 2000)
             // This will fail the build on warnings which are run in a build phase executed by kapt.
-            //option("-Werror")
+            option("-Werror")
         }
     }
 

app/src/main/java/nl/eduvpn/app/EduVPNApplication.java

@@ -20,12 +20,8 @@
 import android.content.Context;
 import android.os.StrictMode;
 
-import org.eduvpn.common.GoBackend;
-import org.eduvpn.common.StateCB;
-
 import de.blinkt.openvpn.core.ICSOpenVPNApplication;
 import nl.eduvpn.app.inject.EduVPNComponent;
-import nl.eduvpn.app.service.BackendService;
 
 /**
  * Application object which keeps track of the app lifecycle.

common/src/main/cpp/jni.cpp

@@ -20,10 +20,10 @@ bool GetJniEnv(JavaVM *vm, JNIEnv **env) {
         if (vm->AttachCurrentThread(env, nullptr) == JNI_OK) {
             did_attach_thread = true;
         } else {
-            // Failed to attach thread. Throw an exception if you want to.
+            // Failed to attach thread
         }
     } else if (get_env_result == JNI_EVERSION) {
-        // Unsupported JNI version. Throw an exception if you want to.
+        // Unsupported JNI version
     }
     return did_attach_thread;
 }