Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add es_419 and es_ES translations #8

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Oct 20, 2023

Description

This PR adds translation support to the plugin. At the moment it only adds the translation to "Spanish (Latin America)" and "Spanish (Spain)".

How to Test

For this plugin to work properly you should have the following requirements:

  1. Install tutor-forum plugin

  2. Enable the plugin and run tutor config save

  3. Build the tutor forum image: tutor images build forum

  4. Install openedx-events in v9.0.0 or higher.

  5. Install edx-platform with this branch

  6. In your environment, configure the following settings. The following plugin is used as reference:

    name: settings
    version: 0.1.0
    patches:
        openedx-common-settings: |
          OPEN_EDX_FILTERS_CONFIG = {
            "org.openedx.learning.instructor.dashboard.render.started.v1": {
              "fail_silently": False,
              "pipeline": [
                "platform_plugin_forum_email_notifier.extensions.filters.AddInstructorNotifierTab",
              ]
            },
          }
          LOCALE_PATHS += ["/openedx/requirements/platform-plugin-forum-email-notifier/platform_plugin_forum_email_notifier/conf/locale"]
    

Afterwards:

Emails

  1. Install this branch in your environment
  2. Go to the discussions page
  3. Create a new post
  4. An email notification should be sent. Those can be found in the lms container in the folder: tmp/openedx/emails. You should see the email translated into your preferred language

Instructor Dashboard

  1. Go to the instructor dashboard
  2. Select the forum notifications tab
  3. You should see all text translated into your preferred language

Screenshots

Emails

  • Creation of a post

    image

  • Response of a post

    image

  • Comment of a post

    image

  • Digest

    image

Instructor Dashboard

image

@BryanttV BryanttV force-pushed the bav/add-translations branch from d97b1d4 to 42c8401 Compare October 20, 2023 21:57
@BryanttV BryanttV marked this pull request as ready for review October 20, 2023 22:20
@BryanttV BryanttV force-pushed the bav/add-translations branch from 42c8401 to fb95520 Compare October 23, 2023 13:56
@BryanttV BryanttV changed the base branch from bav/add-templates to main October 23, 2023 13:57
@BryanttV BryanttV force-pushed the bav/add-translations branch from fb95520 to 4b49800 Compare October 23, 2023 14:12
@BryanttV BryanttV requested a review from a team October 23, 2023 14:13
@mariajgrimaldi
Copy link
Contributor

cc @Ian2012: before merging, we need to try adding LOCALE_PATH as part of the plugin settings, so no additional configuration is needed.

Copy link
Contributor

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@Ian2012 Ian2012 merged commit 8078e0c into main Oct 23, 2023
6 checks passed
@mariajgrimaldi mariajgrimaldi deleted the bav/add-translations branch May 1, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants