ci: set fail-fast as False to allow integration tests to continue on nightly Tutor failures #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jignaciopm
previously approved these changes
Nov 21, 2024
BryanttV
reviewed
Nov 21, 2024
|
@BryanttV @jignaciopm removed 'nightly' from the tutor_versions matrix |
|
@BryanttV turns out |
magajh
force-pushed
the
magagio/allow-integration-tests-to-continue-on-nightly
branch
from
5ecbb5b to
865cce0
Compare
magajh
changed the title
luisfelipec95
approved these changes
Dec 6, 2024
DeimerM
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Tutor Integration Tests workflow to ensure that failures in the nightly version of Tutor do not cancel the execution of tests for stable versions (<18.0.0 and <19.0.0).
fail-fast: falseis added to the strategy, allowing the workflow to proceed even if nightly fails.This change is important because the nightly version of Tutor is not stable and may occasionally fail due to issues unrelated to our tests. By implementing this update, we ensure that failures in nightly do not block critical tests for stable versions.
Note: For more context on why this solution was implemented instead of others, such as continue-on-error, please refer to the conversation in this issue eduNEXT/eox-core#308.