Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for python 3.10 and django 3.2 #222

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

magajh
Copy link
Contributor

@magajh magajh commented Oct 22, 2024

Description:

This PR removes support for Django 3.2 and Python 3.10 from our plugin.

Rationale:

We have decided to drop support for these versions because none of the Open edX releases we support use Django 3.2 or Python 3.10. Therefore, maintaining compatibility with them is unnecessary.

For more context and information, please refer to AP-1490.

Changes:

  • Updated the test workflow to remove Python 3.10 and Django 3.2 from the Python and Django matrix.
  • Updated the tox.ini file to eliminate specifications for Python 3.10 and Django 3.2.
  • Deleted the django32.txt file.
  • Removed constraints that were only necessary for compatibility with Python 3.10 or Django 3.2.
  • Upgraded the requirements using Python 3.8, which is the oldest version we now support.

How to Test:

  • Ensure that all tests in the GitHub CI pipeline pass successfully.
  • Verify that the pipeline no longer runs tests with Python 3.10 and Django 3.2.

@magajh magajh marked this pull request as ready for review October 22, 2024 14:28
@magajh magajh requested a review from a team as a code owner October 22, 2024 14:28
@github-actions github-actions bot added size/m and removed size/s labels Oct 22, 2024
@magajh magajh force-pushed the mjh/drop-support-python3.10-django3.2 branch from 26205de to 2a3d4bf Compare October 22, 2024 18:01
@magajh magajh force-pushed the mjh/drop-support-python3.10-django3.2 branch from 9176330 to 53c21e3 Compare October 22, 2024 18:22
Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this ⭐

@magajh magajh merged commit b160948 into master Oct 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants