Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create edx organization when updating course_org_filter DS-961 #209

Merged
merged 7 commits into from
Jun 6, 2024

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Jun 4, 2024

Description

This PR adds the creation (if it does not exist) of an edX organization each time the course_org_filter property is updated in the LMS Configs of each Tenant Config.

Testing instructions

  1. Install the plugin with these changes (If you are installing it for the first time you should run the migrations).

  2. Create a new Tenant Config from {lms-domain}/admin/eox_tenant/tenantconfig/

  3. In the lms config field add the course_org_filter property and save:

    {
       "course_org_filter": [
          "edunext",
          "edX",
          ...
       ]
    }
  4. Go to {lms-domain}/admin/organizations/organization/, you should see the new organizations.

Additional information

#165

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@Alec4r Alec4r requested review from Alec4r and Asespinel June 4, 2024 16:19
@BryanttV BryanttV force-pushed the bav/create-edx-org branch from 15409a0 to 4fa332a Compare June 4, 2024 17:41
@github-actions github-actions bot added size/s and removed size/xs labels Jun 4, 2024
@BryanttV BryanttV requested a review from a team June 4, 2024 21:09
dcoa
dcoa previously approved these changes Jun 5, 2024
mariajgrimaldi
mariajgrimaldi previously approved these changes Jun 5, 2024
Copy link
Collaborator

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a non-blocking question left to address. Thank you!

@BryanttV BryanttV dismissed stale reviews from mariajgrimaldi and dcoa via e8d4d86 June 5, 2024 16:20
@BryanttV BryanttV force-pushed the bav/create-edx-org branch from 2b251ff to e8d4d86 Compare June 5, 2024 16:20
@BryanttV BryanttV requested review from mariajgrimaldi and dcoa June 5, 2024 16:27
Copy link
Collaborator

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working as expected!

image

@BryanttV BryanttV merged commit fb03ee5 into master Jun 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants