-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused backends DS-960
#208
Conversation
756bd81
to
1680555
Compare
2c253ab
to
d8c8143
Compare
We need to update the compatibility notes to remove the deleted backend in the ironwood notes: https://github.com/eduNEXT/eox-tenant/blob/master/README.rst#compatibility-notes. Also, could you improve the formatting in the compatibility notes table? Thanks! |
Hi @mariajgrimaldi, thanks for the review.
I also thought about doing it, however, @bra-i-am tells me it should not be removed because this backend does exist if we install a version of
Yes, I can format it correctly. |
@BryanttV: good to know, thanks for the explanation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We need to update the compatibility notes to remove the deleted backend in the ironwood notes
@mariajgrimaldi you are right, we need to update not only the compatibility notes but also the whole readme so it is more appropriate and trustable, nevertheless, taking into account that the readme at this moment works as @BryanttV mentioned, I believe we can wait for this card, but if you consider this needs to be done right now, there's no problem to me
Since another card already exists, I will merge with these changes. |
Description
This PR removes unused backends.
The following settings were removed from
common.py
:Additionally, the following modules were removed from
edxapp_wrapper/backends
:edx_auth_i_v1.py
All other backends are currently being used in
common.py
file.Testing instructions
Checklist for Merge