refactor: inherit from social auth exception #117
Annotations
1 error and 2 warnings
commitlint
You have commit messages with errors
⧗ input: refactor: inherit from social auth exception
This change the heritance of the eox-tenant-auth-exception.
This with the purpose of the exception to be handled by the social tpa middleware exception
process.
You can see here that the new class is also based in value error exception.
https://github.com/python-social-auth/social-core/blob/29cbbd22b98d81d569a886b1cc0bd9a316cd124f/social_core/exceptions.py#L1
But the change is related with this PR:
https://github.com/eduNEXT/eox-core/pull/171
So now as the exception is family of the SocialAuthBaseException.
The the tpa middleware could managed it.
https://github.com/python-social-auth/social-app-django/blob/5.4.0/social_django/middleware.py#L35
Keep in mind that this middleware is parent of edx-platform middleware.
https://github.com/openedx/edx-platform/blob/ebcbe1cd9208191c0589d7fe538c6ac13470abe6/common/djangoapps/third_party_auth/middleware.py#L18
✖ footer's lines must not be longer than 100 characters [footer-max-line-length]
⚠ footer must have leading blank line [footer-leading-blank]
✖ found 1 problems, 1 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
|
commitlint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
commitlint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|