feat lti platform: fix rendering: when mimetype of lti_tool_node is i…

…mage/jpeg a non lti module was used. for rendering with iframe use launchPresentation = iframe
edu-sharing · Dec 9, 2022 · 8222b94 · 8222b94
1 parent 619d1fb
commit 8222b94
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/src/main/php/modules/url/mod_url.php b/src/main/php/modules/url/mod_url.php
@@ -14,6 +14,8 @@ private function getEmbedding() {
         $type = $remoteType->getType();
         if(Config::get('urlEmbedding')) {
             $embedding = Config::get('urlEmbedding');
+        }else if ($this -> esObject -> isLti13ToolObject()){
+            $embedding = $this->getLti13ToolEmbedding();
         }else if ($type === RemoteObjectType::$TYPE_VIDEO) {
             $embedding = $this->getVideoEmbedding();
         }else if ($type === RemoteObjectType::$TYPE_AUDIO) {
@@ -26,8 +28,6 @@ private function getEmbedding() {
             $embedding = $this->getH5PEmbedding();
         }else if ($type === RemoteObjectType::$TYPE_PREZI) {
             $embedding = $this->getPreziEmbedding();
-        }else if ($this -> esObject -> isLti13ToolObject()){
-            $embedding = $this->getLti13ToolEmbedding();
         }
         else{
             $embedding = '';
@@ -110,7 +110,9 @@ protected function inline() {
 
         if(Config::get('urlEmbedding')) {
             $embedding = Config::get('urlEmbedding') . $footer;
-        } else if ($type === RemoteObjectType::$TYPE_VIDEO) {
+        }else if ($this -> esObject -> isLti13ToolObject()){
+            $embedding = $this->getLti13ToolEmbedding();
+        }else if ($type === RemoteObjectType::$TYPE_VIDEO) {
             $embedding = $this -> getVideoEmbedding(mc_Request::fetch('width', 'INT', 600), $footer);
         }else if ($type === RemoteObjectType::$TYPE_VIDEO) {
             $embedding = $this->getAudioEmbedding($footer);
@@ -122,8 +124,6 @@ protected function inline() {
             $embedding = $this->getH5PEmbedding($footer);
         }else if ($type === RemoteObjectType::$TYPE_PREZI) {
             $embedding = $this->getPreziEmbedding($footer);
-        }else if ($this -> esObject -> isLti13ToolObject()){
-            $embedding = $this->getLti13ToolEmbedding();
         }else {
             $license = $this -> esObject->getLicense();
             if (!empty($license))
@@ -214,8 +214,15 @@ protected function getImageEmbedding($footer = '')
 
     protected function getLti13ToolEmbedding($footer = ''){
         return '<div>
-            <iframe src="'. $this->getUrl().'&editMode=false" style="max-width: 100%;width:100%;height: 100%;"></iframe>
+            <iframe src="'. $this->getUrl().'&editMode=false&launchPresentation=iframe" style="max-width: 100%;width:100%;height: 100%;"></iframe>
             ' . $footer . '</div>';
+
+        /**
+         *   protected function getLti13ToolEmbedding($footer = ''){
+        return '<div> <iframe src="'. $this->getUrl().'&editMode=false" style="max-width: 100%;width:100%;height: 100%;" onLoad="this.style.height=contentWindow.document.documentElement.scrollHeigh>
+        }
+
+         */
     }
 
     protected function getVideoEmbedding($width = NULL, $footer = '') {