Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifies text content of accessibility information keys #2716

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

gautierchomel
Copy link
Member

Very partial update implementation of display guide 2.0. See #2536

Very partial update implementation of display guide 2.0.
See #2536
@llemeurfr
Copy link
Contributor

@gautierchomel do you insist having long a11y descriptions in Thorium? We only have limited space in the Information modal box, not a large HTML page, as some retailers propose on their websites.
You're the a11y expert, therefore you will choose, but my warning is that with the long descriptions, the Information box will be bloated with a11y information (when it exists for the book).

@gautierchomel
Copy link
Member Author

current available space seems large enough
image

@gautierchomel
Copy link
Member Author

gautierchomel commented Dec 17, 2024

This is how it looks on the shorter possible screen (first screen shot is a standard ebook while the second one is the all informations testing ebook). In both cases, it does not adds a line. To me it's a better use of the space (less white space on the right).
image
image

@gautierchomel
Copy link
Member Author

gautierchomel commented Dec 17, 2024

In any case, it a a very partial and temporary implementation of the new guide, only shifting the existing words to ship something in the Thorium 3.1 instead of remaining with the old wording.

Full guide implementation will need more work as it comes with variants values for each keys (Readable in read aloud or dynamic braille; May not be fully readable in read aloud or dynamic braille; Not fully readable in read aloud or dynamic braille; No information is available).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants