fix(ts): set payload to unknown value type #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
added a commit
to epicweb-dev/web-forms
that referenced
this pull request
Aug 24, 2023
edmundhung/conform#272 Until that is merged, we need to manually update it in node_modules
|
The TS team also suggests to use |
MichaelDeBoey
approved these changes
Aug 24, 2023
kentcdodds
added a commit
to epicweb-dev/data-modeling
that referenced
this pull request
Aug 25, 2023
with manual edmundhung/conform#272
|
Can confirm that this fix works with the new
|
edmundhung
force-pushed
the
submission-any-to-unknown
branch
from
b8717a3
to
d2bcf1c
Compare
The Jsonify utility used by Remix will make a `Record<string, any>` disappear in the type: remix-run/remix#7246 But considering this further, "unknown" is a safer option for this type anyway because it avoids issues with accidentally accessing the values off the submission payload without first checking them. So I do think this change should be made.
edmundhung
force-pushed
the
submission-any-to-unknown
branch
from
d2bcf1c
to
ede57a1
Compare
|
Any progress on this? 😬 |
|
I will update the remix fixture to v2 (pre) this weekend to verify the change and make a release. I was betting the issue to be resolved upstream soon so I don't need to bump the minor version now (This is a breaking change unfortunately). But it looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Jsonify utility used by Remix will make a
Record<string, any>disappear in the type: remix-run/remix#7246But considering this further, "unknown" is a safer option for this type anyway because it avoids issues with accidentally accessing the values off the submission payload without first checking them. So I do think this change should be made.