Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Persian translations added #41

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

CodeWithEmad
Copy link
Contributor

@CodeWithEmad CodeWithEmad commented Sep 14, 2024

This PR introduces:

  • New Persian translations.
  • Collected new source (English) messages
  • Some cleanup with GitHub actions
  • Fixes in "Working with translations" section in README

Copy link
Contributor

@ziafazal ziafazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

uses: actions/setup-python@v5
with:
python-version: '3.12'
- name: Set up Python ${{ matrix.python-version }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove ${{ matrix.python-version }} because we are no longer using it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@ziafazal ziafazal merged commit 1ed45c3 into edly-io:master Sep 20, 2024
1 check passed
@CodeWithEmad CodeWithEmad deleted the feat/persian-translations branch September 20, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants