Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flag API positional arguments #603

Closed
wants to merge 1 commit into from

Conversation

Faraz32123
Copy link

It will fix the error faced while hitting flag API from frontend.

  • made use of keyword arguments wherever missing to avoid any error due to position of argument
  • Add mock tests for code coverage

@Faraz32123 Faraz32123 marked this pull request as ready for review December 5, 2024 06:30
@Faraz32123 Faraz32123 force-pushed the edly/fix_forum_v2_report_api_call branch from cef4688 to 014cc0f Compare December 5, 2024 07:19
To reproduce the error:
- switch to mongodb from mysql for a specific course.
- create a thread and report the thread. It'll throw an error due to wrong positioning of the arguments.

So, this commit
- uses keyword arguments in flag APIs
- adds mock tests for code coverage
@Faraz32123 Faraz32123 force-pushed the edly/fix_forum_v2_report_api_call branch from 014cc0f to 6ea7389 Compare December 5, 2024 11:14
@Faraz32123 Faraz32123 closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant