Introduce DI & migrate tools builders #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e11sy
reviewed
Aug 29, 2024
| @@ -41,21 +45,33 @@ export default class Core { | |||
| */ | |||
| #caretAdapter: CaretAdapter; | |||
|
|
|||
| #iocContainer: ContainerInstance; | |||
|
|
||
| this.#availableTools.set(toolName, tool); | ||
|
|
||
| console.log(this.#availableTools.entries()); |
neSpecc
reviewed
Aug 29, 2024
neSpecc
reviewed
Aug 29, 2024
|
⏭️ No files to mutate for |
|
⏭️ No files to mutate for |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 0/0 |
| 🟢 | Branches | 100% | 0/0 |
| 🟢 | Functions | 100% | 0/0 |
| 🟢 | Lines | 100% | 0/0 |
Test suite run success
1 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 1ab1a6a
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 753/753 |
| 🟢 | Branches | 99.5% | 201/202 |
| 🟢 | Functions | 98.37% | 181/184 |
| 🟢 | Lines | 100% | 725/725 |
Test suite run success
389 tests passing in 24 suites.
Report generated by 🧪jest coverage report action from 1ab1a6a
neSpecc
reviewed
Aug 29, 2024
|
|
||
| this.#factory = new ToolsFactory(this.#config, editorConfig, {}); | ||
|
|
||
| void this.#prepareTools(); |
There was a problem hiding this comment.
im not sure that this promise should be ignored. Maybe you can await it in somewhere Core
There was a problem hiding this comment.
I made the method public, let's await it once isReady api is implemented
Co-authored-by: Peter <[email protected]>
e11sy
approved these changes
Aug 29, 2024
neSpecc
approved these changes
Aug 29, 2024
nikmel2803
pushed a commit
that referenced
this pull request
Aug 30, 2024
* Introduce DI & migrate tools builders * Fixes after review * 'Fix' lint * Add unsaved files * Fix comments * Remove log & add docs * Update packages/core/src/entities/UnifiedToolConfig.ts Co-authored-by: Peter <[email protected]> * Fixes after review --------- Co-authored-by: Peter <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
* fix tests * use new method in the model * add ci for collab manager * lint fixes * add getters for the index * fix tests * move methods to the document * lint * use helpers * add tests * Introduce DI & migrate tools builders (#80) * Introduce DI & migrate tools builders * Fixes after review * 'Fix' lint * Add unsaved files * Fix comments * Remove log & add docs * Update packages/core/src/entities/UnifiedToolConfig.ts Co-authored-by: Peter <[email protected]> * Fixes after review --------- Co-authored-by: Peter <[email protected]> * Add BlockManager and EditorUI classes (#85) * Add BlockManager and EditorUI classes * Add JSDocs * Add try catch for block.render() call * feat(core): inputs content rendering (#86) * passing formattingadapter to blocktooladapter * lint * Update BlockManager.ts * Update BlockManager.ts * Update App.vue * Add Toolbox & ToolboxUI (#88) * Add Toolbox & ToolboxUI * Add comments * Update tests for the model package * Fix lint * feat(dom-adapters): Inline tool adapter check for tool required data (#87) * Implmenet global CaretAdapter * Handle native inputs * Pass input type to Input component props * Use class to represent index * Fix lint in dom-adapters * fix linter * added inline tool adapter * implement model updates * lint fix * fix index * adapter renders inline tools * lint fix and clean up * jsdoc * clean up * jsdoc * jsdoc * surround content replaced * suggestions * lint fix * jsdoc * added bold and italic inline tools into core package * naming * naming * added inline toolbar and inlineToolAdapter init into core * update packages and lock * build fix * implement inline tool adapter to core - fully implement current realization of inline tool adapter to core - remove from the playground * clean up * jsdoc and naming improvements * naming * naming * renaming * fix hardcoded * tools are initialized inside of the inline toolbar initialization * fixed inline tool attaching * jsdoc * naming fix * fixed imports * lint fix * try build fix * install dependencies * add sdk package * fix build for core * change package name in actions * add references * typo * fix build * added inline tool data former * fix lint * rm unwanted changes * lint fix * fixed build * docs improved * fix build * naming improved * Update packages/core/src/ui/InlineToolbar/index.ts Co-authored-by: Peter <[email protected]> * Update packages/dom-adapters/src/FormattingAdapter/index.ts Co-authored-by: Peter <[email protected]> * rm unwanted change * naming * separated renderToolActions and apply method in formatting adapter * naming * moved surround to utils * lint fix * last naming fix 🤞 * made renderToolActions method private --------- Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Peter <[email protected]> * fix linter --------- Co-authored-by: George Berezhnoy <[email protected]> Co-authored-by: Peter <[email protected]> Co-authored-by: e11sy <[email protected]> Co-authored-by: George Berezhnoy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.