build: Upgrade to go-1.21 and Alpine 3.18 #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestojeda
added
the
ci
Signed-off-by: Ernesto Ojeda <[email protected]>
ernestojeda
force-pushed
the
go-1.21
branch
from
9bbe69e to
db6b7c2
Compare
5 tasks
ernestojeda
commented
Sep 15, 2023
|
|
||
| # Install Chromium for automated testing. | ||
| RUN apk add --no-cache chromium | ||
| ENV CHROME_BIN=/usr/bin/chromium-browser | ||
| ENV NODE_OPTIONS=--openssl-legacy-provider |
There was a problem hiding this comment.
Temporary workaround to get the build working. However, we need to update dependencies in package.json. To get the correct fixes.
There was a problem hiding this comment.
@A808597949 @Ambition-J for awareness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-ui-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)