Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct service key for security proxy auth #5020

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jinlinGuan
Copy link
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@jinlinGuan jinlinGuan requested a review from cloudxxx8 December 9, 2024 07:53
Copy link

sonarcloud bot commented Dec 9, 2024

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.07%. Comparing base (6bbd37b) to head (dc34042).

Files with missing lines Patch % Lines
internal/security/proxyauth/main.go 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5020   +/-   ##
=======================================
  Coverage   28.07%   28.07%           
=======================================
  Files         243      243           
  Lines       17590    17590           
=======================================
  Hits         4938     4938           
  Misses      11524    11524           
  Partials     1128     1128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cloudxxx8 cloudxxx8 merged commit 2eb6d4b into edgexfoundry:main Dec 9, 2024
7 checks passed
@jinlinGuan jinlinGuan deleted the fix-proxy-auth branch December 9, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants