Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new export error metrics to App Service common config #4696

Merged

Conversation

lenny-goodell
Copy link
Member

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    feat: Document new app service export error metrics edgex-docs#1237

Testing Instructions

Run non-secure Edgex Stack
View http://localhost:8500/ui/dc1/kv/edgex/v3/core-common-config-bootstrapper/app-services/Writable/Telemetry/Metrics/
Verify HttpExportErrors and MqttExportErrors are not present
build and run core-common-config-bootstrapper with overwrite flag

./core-common-config-bootstrapper -o -cp

View http://localhost:8500/ui/dc1/kv/edgex/v3/core-common-config-bootstrapper/app-services/Writable/Telemetry/Metrics/
Verify HttpExportErrors and MqttExportErrors are now present

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell added the enhancement New feature or request label Sep 27, 2023
@lenny-goodell lenny-goodell added this to the Napa milestone Sep 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@ejlee3 ejlee3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #4696 (7dd5273) into main (ca71810) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #4696   +/-   ##
=======================================
  Coverage   41.55%   41.55%           
=======================================
  Files         105      105           
  Lines        9834     9834           
=======================================
  Hits         4087     4087           
  Misses       5395     5395           
  Partials      352      352           

@lenny-goodell lenny-goodell merged commit a045e8e into edgexfoundry:main Sep 27, 2023
7 checks passed
@lenny-goodell lenny-goodell deleted the new-app-service-metrics branch September 27, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants