build: Pull spire-server and spire-agent from prebuilt containers #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-wang-intel
previously approved these changes
Aug 30, 2023
Signed-off-by: Bryon Nevis <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Thanks, @jim-wang-intel . I added github container registry to the allow list. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4667 +/- ##
=======================================
Coverage 41.88% 41.88%
=======================================
Files 105 105
Lines 9702 9702
=======================================
Hits 4064 4064
Misses 5296 5296
Partials 342 342 |
jim-wang-intel
approved these changes
Aug 31, 2023
|
Validation completed on aarch64 vm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIRE project is now publishing prebuilt containers for linux/amd64 and linux/arm64 on their github project that have statically-linked spire-server and spire-agent components. Rather than building locally, we can just reference the GHCR containers in a FROM line and directly pull in the binaries, without having to waste time building them.
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
"make docker" in this repo and "make run dev delayed-start ds-virtual" in edgex-compose/compose-builder and ensure all containers start properly. This should be tested both on Intel and ARM64 architectures to be valid.
New Dependency Instructions (If applicable)