Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build spire service with Golang 1.21 #4666

Closed
weichou1229 opened this issue Aug 30, 2023 · 6 comments
Closed

Docker build spire service with Golang 1.21 #4666

weichou1229 opened this issue Aug 30, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@weichou1229
Copy link
Member

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for spire services

Description [REQUIRED]

If we want to build the docker image with Golang 1.21, the spire services require the sipre repo to release a new version with Goland 1.21 changes spiffe/spire@4d96a37

@weichou1229 weichou1229 added the enhancement New feature or request label Aug 30, 2023
@github-project-automation github-project-automation bot moved this to New Issues in Technical WG Aug 30, 2023
@jumpingliu jumpingliu moved this from New Issues to In Progress in Technical WG Aug 30, 2023
@jumpingliu jumpingliu changed the title Docker buiild spire service with Golang 1.21 Docker build spire service with Golang 1.21 Aug 30, 2023
@cloudxxx8 cloudxxx8 moved this from In Progress to New Issues in Technical WG Aug 30, 2023
@bnevis-i bnevis-i self-assigned this Aug 30, 2023
@lenny-goodell
Copy link
Member

@weichou1229 , please add details about issue you ran into with building spire services docker images.

@bnevis-i
Copy link
Collaborator

FYI: The last spire release was on August 16 and the golang 1.21 support was merged on August 21.

@bnevis-i
Copy link
Collaborator

It looks like the project is now publishing multi-arch (amd64, arm64) docker images on their github. I may be able to change the build process to download an arch-specific static linked binary instead of recompiling on the fly, or even use the upstream containers.

@bnevis-i
Copy link
Collaborator

I have a draft PR out here that I am going to regress.

#4667

If this works, we can remove spire server and agent from the build cache as well as from local build.

@jumpingliu jumpingliu moved this from New Issues to Release Backlog in Technical WG Aug 31, 2023
@bnevis-i bnevis-i assigned ernestojeda and unassigned bnevis-i Sep 5, 2023
@bnevis-i
Copy link
Collaborator

bnevis-i commented Sep 5, 2023

Reassigning to Ernesto, who will be making a corresponding change in ci-build-images which should button this one up.

@jumpingliu jumpingliu removed the status in Technical WG Sep 5, 2023
@jumpingliu jumpingliu moved this to Release Backlog in Technical WG Sep 5, 2023
@ernestojeda
Copy link
Contributor

Latest v1.21 golang base image now uses pre-built spire-server and spire-agent

See:
https://github.com/edgexfoundry/ci-build-images/blob/golang-1.21/Dockerfile#L26-L27

@github-project-automation github-project-automation bot moved this from Release Backlog to Napa Done in Technical WG Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants