refactor!: remove legacy metrics api, event publishing to core-data #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iain-anderson
force-pushed
the
remove-metrics-and-core-data
branch
from
108588c to
781a83b
Compare
iain-anderson
force-pushed
the
remove-metrics-and-core-data
branch
from
781a83b to
eafbf3d
Compare
BREAKING CHANGE: Removed the Device.UseMessageBus config, the code for sending event via core-data REST client and the Clients.core-data dependency (MessageBus is always enabled in 3.0 for sending events) BREAKING CHANGE: v2 metrics endpoint is removed for all services Signed-off-by: Iain Anderson <[email protected]>
iain-anderson
force-pushed
the
remove-metrics-and-core-data
branch
from
eafbf3d to
2707c1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Removed the Device.UseMessageBus config, the code for sending event via core-data REST client and the Clients.core-data dependency (MessageBus is always enabled in 3.0 for sending events)
BREAKING CHANGE: v2 metrics endpoint is removed for all services
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-c/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Closes #439
See also edgexfoundry/device-sdk-go#1301 and edgexfoundry/device-sdk-go#1298
Testing Instructions
New Dependency Instructions (If applicable)