fix: JSON formatted logs for all Coordinator and marble-injector messages #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marblerun-docs canceled.
|
daniel-weisse
force-pushed
the
dw/http-json-logging
branch
2 times, most recently
from
97104b1 to
41a8290
Compare
thomasten
approved these changes
Nov 15, 2024
internal/logging/logging.go
Outdated
| return log.New(logWrapper{zapLogger}, "", 0) | ||
| } | ||
|
|
||
| // loggerWrapper implements [io.Writer] by writing any data to the error level of the embedded [*zap.Logger]. |
There was a problem hiding this comment.
Suggested change
| // loggerWrapper implements [io.Writer] by writing any data to the error level of the embedded [*zap.Logger]. | |
| // logWrapper implements [io.Writer] by writing any data to the error level of the embedded [*zap.Logger]. |
nit
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse
force-pushed
the
dw/http-json-logging
branch
from
41a8290 to
64de744
Compare
daniel-weisse
added
the
bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
zap.Loggerfor JSON formatted logs instead of Go's standard librarylog.Logger