Let Coordinator serve monotonic counters to Marbles #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marblerun-docs canceled.
|
daniel-weisse
approved these changes
Oct 8, 2024
coordinator/core/marbleapi.go
Outdated
Comment on lines
162
to
168
| // Add Coordinator root cert to env so that Marbles can use the Coordinator client API | ||
| coordinatorRootCert, err := getCoordinatorRootCertAsPEM(txdata) | ||
| if err != nil { | ||
| c.log.Error("Couldn't retrieve Coordinator root certificate", zap.Error(err)) | ||
| return nil, status.Errorf(codes.Internal, "retrieving Coordinator root certificate: %s", err) | ||
| } | ||
| params.Env[globalconstants.MarbleEnvironmentCoordinatorRootCA] = coordinatorRootCert |
There was a problem hiding this comment.
We should do this in customizeParameters where we already add other certificates to env variables
There was a problem hiding this comment.
Do you prefer passing txdata to customizeParameters or passing coordinatorRootCert and moving just the last line into customizeParameters?
There was a problem hiding this comment.
We currently use the reservedSecrets struct to pass around marble and (intermediate) root certificates, lets add it there.
That would also allow us to reference the "true" root certificate in the manifest through {{ .MarbleRun.<certName> }}
not entirely sure what to call the cert yet, since we also reserved RootCA for the Marble Root certificate.
Maybe CoordinatorRoot could work here
daniel-weisse
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds monotonic counters managed by the Coordinator, which Marbles can obtain via the client API.
A counter is bound to Marble type and UUID, as well as a name defined by the Marble developer.
Proposed changes