image: add rpm database as build output #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
malt3
force-pushed
the
fix/image/rpmdb
branch
from
0b71c53 to
54f0ca6
Compare
|
@thomasten FYI |
thomasten
reviewed
Oct 12, 2023
msanft
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Can't say much regarding the internal system-level logic of this change, as i'm not very familiar with mkosi and our image build in general. High-level reasoning of the change sounds good to me and Bazel files, shell scripts and GH action looks good as well. LGTM from my (limited) POV
malt3
force-pushed
the
fix/image/rpmdb
branch
from
54f0ca6 to
1340ce0
Compare
For reproducibility reasons, the final OS image does not ship the rpm database in sqlite format. For supply chain security and license compliance reasons, we want to keep the rpm database of os images as a detached build artifact. We now ship a reproducible, human readable manifest of installed rpms in the image under "/usr/share/constellation/packagemanifest" and upload the full rpm database as a build artifact (rpmdb.tar).
malt3
force-pushed
the
fix/image/rpmdb
branch
from
1340ce0 to
a7038cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For reproducibility reasons, the final OS image does not ship the rpm database in sqlite format. For supply chain security and license compliance reasons, we want to keep the rpm database of os images as a detached build artifact. We now ship a reproducible, human readable manifest of installed rpms in the image under "/usr/share/constellation/packagemanifest" and upload the full rpm database as a build artifact (rpmdb.tar).
Proposed change(s)
Checklist