Skip to content

Commit

Permalink
Added tests and changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
edefimov committed May 25, 2015
1 parent 0b0ed3d commit 2c4293a
Show file tree
Hide file tree
Showing 6 changed files with 516 additions and 256 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Changelog

0.1.1 (May 25, 2015)
--------------------
- Added additional checks due to https://bugs.php.net/bug.php?id=64803

0.1.0 (May 19, 2015)
--------------------
- First library release
4 changes: 2 additions & 2 deletions src/Socket/AbstractSocket.php
Original file line number Diff line number Diff line change
Expand Up @@ -230,12 +230,12 @@ private function writeActualData($data)
{
$test = stream_socket_sendto($this->resource, '');
if ($test !== 0) {
$this->throwNetworkSocketException('Socket write failed.');
$this->throwNetworkSocketException('Failed to send data.');
}

$written = fwrite($this->resource, $data, strlen($data));
if ($written === false) {
$this->throwNetworkSocketException('Socket write failed.');
$this->throwNetworkSocketException('Failed to send data.');
}

if ($written === 0) {
Expand Down
3 changes: 0 additions & 3 deletions tests/Event/WriteEventTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,7 @@
namespace Tests\AsyncSockets\Event;

use AsyncSockets\Event\EventType;
use AsyncSockets\Event\ReadEvent;
use AsyncSockets\Event\WriteEvent;
use AsyncSockets\Socket\ChunkSocketResponse;
use AsyncSockets\Socket\SocketResponse;

/**
* Class ReadEventTest
Expand Down
2 changes: 1 addition & 1 deletion tests/Mock/PhpFunctionMocker.php
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ private static function getFunctionArgumentList(\ReflectionFunction $function)
}

/**
* Conver parameter value to string
* Convert parameter value to string
*
* @param mixed $value Value
*
Expand Down
Loading

0 comments on commit 2c4293a

Please sign in to comment.