Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate event date and time copying #572

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vishwasja
Copy link
Contributor

  • Replaced scheduled_at datetime field with seperate date and time field
  • Added changes in controller to join date and time in controller to save as scheduled_at

In copy event if the scheduled_at date and time BOTH are provided ONLY then the scheduled_at is update for the copied events.

Ticket #545

- Replaced scheduled_at datetime field with seperate date and time field
- Added changes in controller to join date and time in controller to save as scheduled_at
@anthonycrumley
Copy link
Contributor

@vishwasja There is a failing test on Travis CI.

- Replaced scheduled_at with scheduled_at_date and scheduled_at_time
@vishwasja
Copy link
Contributor Author

@anthonycrumley Fixed failing tests.

Copy link
Contributor

@anthonycrumley anthonycrumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change and sorry for the delay. Please see comment about scheduled at time editing.

</div>
<div class="col-sm-6" style="padding-right: 0;">
<div class="input-group date" id="event-timepicker">
<input type='text' class="form-control" name="network_event[scheduled_at_time]" id="network_event_scheduled_at" value="<%= @network_event.scheduled_at %>" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishwasja This time value does not seem to be working correctly. An event created with a scheduled time of 11:00am is showing as 8:00pm when edited.
ed_network
ed_network

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants