Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-2587] Add market metadata on market page #463

Merged
merged 9 commits into from
Dec 19, 2024
Merged

[ECO-2587] Add market metadata on market page #463

merged 9 commits into from
Dec 19, 2024

Conversation

CRBl69
Copy link
Collaborator

@CRBl69 CRBl69 commented Dec 13, 2024 •
edited
Loading

Test

Go to the vercel preview then to /dev/metadata.

Set some metadata for your market.

Go to your market and check that everything is all right.

Alternatively, check eagle money.

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 2:46am
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 2:46am

@CRBl69 CRBl69 marked this pull request as ready for review December 17, 2024 13:44
@CRBl69 CRBl69 requested review from xbtmatt and alnoki December 17, 2024 13:44
@CRBl69
Copy link
Collaborator Author

CRBl69 commented Dec 17, 2024

Change contract to coin

xbtmatt
xbtmatt requested changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@xbtmatt xbtmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove set copied, since it was a holdover from the emoji copy paste design
  2. Try to remove the market cap/volume numbers from re-scrambling when clicking "Copy address'

Then this looks good to me! Looks great

@alnoki alnoki requested a review from xbtmatt December 18, 2024 19:45
@xbtmatt xbtmatt merged commit 9af3c84 into main Dec 19, 2024
7 checks passed
@xbtmatt xbtmatt deleted the ECO-2587 branch December 19, 2024 03:11
xbtmatt added a commit that referenced this pull request Dec 20, 2024
@CRBl69 @xbtmatt
[ECO-2587] Add market metadata on market page (#463)
5ccaea7 
Co-authored-by: Matt <[email protected]>
@xbtmatt xbtmatt mentioned this pull request Dec 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alnoki alnoki alnoki left review comments

@xbtmatt xbtmatt xbtmatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CRBl69 @alnoki @xbtmatt