[ECO-2489] Add emojicoin arena Move prototype #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alnoki
changed the title
alnoki
commented
Nov 26, 2024
alnoki
commented
Dec 19, 2024
xbtmatt
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
I think we discussed today that you'd update the lock in functionality, so I expect some of this will change.
I personally think you could merge this in just so we can more clearly see the new changes for the lock in stuff when you add it, that way the PR doesn't become a monolith, since I think this effectively does cover the initial implementation / design specs, but I will just leave an approving review for you to decide!
Co-authored-by: Matt <[email protected]>
alnoki
changed the title
xbtmatt
added a commit
that referenced
this pull request
Dec 21, 2024
Co-authored-by: Matt <[email protected]>
xbtmatt
added a commit
that referenced
this pull request
Dec 21, 2024
Co-authored-by: Matt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The emojicoin arena is a gamified experience where users deposit coins into escrow and trade between two emojicoins that are active in a "melee", which restarts every 36 hours with a new randomly selected combination of registered emojicoin markets. By depositing into escrow users can have their PnL tracked, and certain restrictions can be enforced, e.g. holding all melee deposits in one of two emojicoins, and holding through to the end of the melee ("locking in") if the user accepts rewards.
Note that the core design for review includes:
entry funAPIs (which rely on randomness to crank the schedule)Checklist