[ECO-2161] Update market page with new grace period dynamics #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xbtmatt
reviewed
Oct 7, 2024
src/typescript/frontend/src/lib/hooks/queries/use-grace-period.ts
Outdated
Show resolved
Hide resolved
xbtmatt
reviewed
Oct 7, 2024
src/typescript/frontend/src/lib/hooks/queries/use-grace-period.ts
Outdated
Show resolved
Hide resolved
xbtmatt
reviewed
Oct 7, 2024
src/typescript/frontend/src/lib/hooks/queries/use-grace-period.ts
Outdated
Show resolved
Hide resolved
…stable reference to `props.data.symbol` and `queryClient` Move grace period message to the top of the file Put the `canTrade` logic into a `useMemo` Add `numSwaps` to the `SwapButton` props so it re-renders properly when the # of swaps changes ready Clean up and consolidate hook logic, decouple the fetch logic from display interval logic Disable `useQuery` hook from fetching once the market is not in grace period
xbtmatt
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Awesome, I sort of re-arranged a few things, but mostly kept the logic the same.
The main difference is I put the refetching logic into useQuery in the enabled field and then stop fetching when the market is out of the grace period.
I also changed the format to be 00:00 for the time left, since it was too big when looking at it on mobile. That was it though :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the new grace period dynamics:
In order to prevent the market registrant to trade on his own market, in case
of query failure, the UI will let anyone try to trade.
On trade, the grace period is automatically updated !
Screenshots
Testing
Go to vercel, register a market, go on the market page with two different accounts (registrant and another one).
Checklist