-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-2152] Segment REST and WS endpoints for dual load balancer schema #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alnoki
changed the title
[ECO-2152] Endpoint protections
[ECO-2152] Segment REST and WS endpoints for dual load balancer schema
Sep 3, 2024
CRBl69
approved these changes
Sep 4, 2024
xbtmatt
reviewed
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR segments the REST and WS endpoints into separate subdomains through
internal load balancer refactors that will enable rate limiting and caching in
subsequent updates.
CloudFormation
Link, to enable add-on rate limiting and caching in subsequent updates.
to public ALB due to aforementioned difficulties with header forwarding. Note
that rate limiting can still be applied to the ALB, even though caching is
not meaningful for the WS endpoint.
[ECO-2145] Add health route aptos-indexer-processors#45.
Broker path updates
/
on broker./
health check to be/live
.consistency with Docker images pushed to Docker Hub.
apt-get install
versions major.Testing
the README instructions for both public endpoints and bastion host, using the
CLI to send in chat events.
MaybeDeployStack
tofalse
toverify no update hangs during de-provisioning.
MaybeDeployStack
totrue
to verify full stack provisioningfrom genesis, which will happen on
main
when this lands sincemain
iscurrently de-provisioned.
Checklist