Events per signal instance #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wegendt-bosch
force-pushed
the
events-per-signal-instance
branch
from
1899a41 to
ecbb9f2
Compare
csweichel
approved these changes
Nov 29, 2019
Comment on lines
-185
to
-187
| if(tv.idx == 2679 && typ.toString == "uint32") { | ||
| print("") | ||
| } |
| @@ -219,7 +219,7 @@ class RingbufferGenerator extends AbstractTypeGenerator { | |||
| ), | |||
| true | |||
| )» | |||
| «rbRef.code».length++; | |||
| ++«rbRef.code».length; | |||
There was a problem hiding this comment.
is this just a readability issue or did this produce compilation errors?
There was a problem hiding this comment.
In general, preincrement > postincrement, since the latter generates a temporary copy ;)
bundles/org.eclipse.mita.program/src/org/eclipse/mita/program/generator/GeneratorUtils.xtend
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.mita.program/src/org/eclipse/mita/program/generator/GeneratorUtils.xtend
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| override getLibraries() { | ||
| return #["paho-mqtt3c"] |
There was a problem hiding this comment.
should we ping the Paho guys as Mita now has Paho on x86 support? :D
| @@ -73,11 +73,11 @@ class EventLoopGenerator implements IPlatformEventLoopGenerator { | |||
| } | |||
|
|
|||
| override generateSetupPreamble(CompilationContext context) { | |||
| val startupEventHandler = context.allEventHandlers.filter[it.event instanceof SystemEventSource].findFirst[(it.event as SystemEventSource).source.name == "startup"] | |||
| val startupEventHandlers = context.allEventHandlers.filter[it.event instanceof SystemEventSource].filter[(it.event as SystemEventSource).source.name == "startup"] | |||
There was a problem hiding this comment.
do resources other than the platform allow startup handler, too?
There was a problem hiding this comment.
you might have more than one startup handler for the event
wegendt-bosch
force-pushed
the
events-per-signal-instance
branch
from
2509f97 to
5abdb17
Compare
PriyaGovind
pushed a commit
to PriyaGovind/mita
that referenced
this pull request
Apr 15, 2020
* Implement events per signal instance * Implement user specified event handler buffer sizes * Implement MQTT on x86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #344.