Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update liberty config #483

Closed
wants to merge 1 commit into from
Closed

update liberty config #483

wants to merge 1 commit into from

Conversation

Emily-Jiang
Copy link
Member

No description provided.

@scottkurz
Copy link
Contributor

I'll close #477 then since this supersedes.

@scottkurz scottkurz mentioned this pull request Jun 6, 2023
Closed
@scottkurz
Copy link
Contributor

scottkurz commented Jun 13, 2023 •
edited
Loading

@Emily-Jiang sent a PR to your PR branch.
Emily-Jiang#2

Also please see my #484 separately (but next time you release).

@scottkurz
Copy link
Contributor

Hmm...looking at the failure and recreating locally... I don't think the Liberty Gradle 3.6 is compatible with the 6.8.3 gradle wrapper.

It did work when I backed off to io.openliberty.tools:liberty-gradle-plugin:3.5.2. Will try to follow-up to understand better.

@scottkurz scottkurz mentioned this pull request Jun 20, 2023
Open
@scottkurz
Copy link
Contributor

scottkurz commented Jul 6, 2023 •
edited
Loading

The GHA check failure showed:

 * What went wrong:
Execution failed for task ':installLiberty'.
> java.io.EOFException: Unexpected end of ZLIB input stream

This would seem to be when the two ./gradlew libertyPackage cmds, for A and B, are executed concurrently.

Next step is to understand why this is the case.

@scottkurz scottkurz mentioned this pull request Jul 6, 2023
Merged
@Emily-Jiang
Copy link
Member Author

Thank you @scottkurz ! I'll close this PR and push #486 forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emily-Jiang @scottkurz