Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the KumuluzEE implementation for the schedule microservice #169

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TFaga
Copy link

@TFaga TFaga commented Sep 19, 2017

No description provided.

@OndroMih
Copy link
Contributor

I tried to build with mvn install -DskipTests and I got an exception when the app was started:

[ERROR] java.lang.NoClassDefFoundError: org/objectweb/asm/ClassVisitor
[ERROR]     a  t  org.eclipse.je tty.annotations.AnnotationConfiguration.createAnnotationParser(AnnotationConfiguration.java:506)
[ERROR]     a  t  org.eclipse.je tty.annotations.AnnotationConfiguration.scanForAnnotations(AnnotationConfiguration.java:421)
[ERROR]     a  t  org.eclipse.je tty.annotations.AnnotationConfiguration.configure(AnnotationConfiguration.java:363)

When I then executed the JAR from command line it was OK. So I think it's enough if the build doesn't start the app, only builds the JAR.

@TFaga
Copy link
Author

TFaga commented Sep 20, 2017

I see. I've put the tests to run as part of the integration-test phase, I'll try and move them to the test phase or make sure to disable them if the option is passed, so they can be skipped when installing.

@OndroMih
Copy link
Contributor

@TFaga, have you signed the Eclipse Contributor Agreement? If yes, did you use [email protected] with Eclipse? Otherwise, please see https://www.eclipse.org/legal/ECA.php to sign the agreement, so that we may accept your PRs.

…odule when supplying the -DskipTests property on maven build

Signed-off-by: Tilen Faganel <[email protected]>
@TFaga
Copy link
Author

TFaga commented Sep 21, 2017

I've added the tests to a profile that is disabled when -DskipTests is used. Just signed the agreement, should be OK now.

@TFaga
Copy link
Author

TFaga commented Sep 30, 2017

We have added KumuluzEE implementations of the Schedule and the Speaker microservices. Both services have Health (/health endpoint), Metrics (/metrics) and Config included and implemented. For Metrics, there is also a Prometheus exporter accessible on /prometheus (which is a nice addition for the demo).

@pilhuhn
Copy link

pilhuhn commented Sep 30, 2017 via email

@TFaga
Copy link
Author

TFaga commented Oct 1, 2017

We have mapped the Prometheus to /prometheus endpoint and JSON output to /metrics endpoint, in order to better demonstrate both of the formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants