Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard matching doc #639

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

argerus
Copy link
Contributor

@argerus argerus commented Aug 15, 2023

No description provided.

@SebastianSchildt
Copy link
Contributor

(Readable: https://github.com/boschglobal/kuksa.val/blob/feature/wildcard_matching_doc/doc/wildcard_matching.md )

Look quite sensible to me. Apart from content, some notes:

Once we have plumbing for that in databroker we should also make gherkin/cucumber tests for it, the table in markdown looks already almost "executable"

Also, instead of just having this file "waiting to be found", we should then reference it from the authorisation.md document and in the API doc if we ahem had any (we do at least have a little bit in wiki https://github.com/eclipse/kuksa.val/wiki/KUKSA.val-gRPC-interfaces)

@argerus argerus force-pushed the feature/wildcard_matching_doc branch 3 times, most recently from dbf6d21 to 5f364b4 Compare August 24, 2023 08:35
@SebastianSchildt
Copy link
Contributor

Looks good to me, but should only be merged after #641

Should explicitly mention that the expansion rules are applied in the kuksa.val.v1 API paths as well as Expansion of authorisation tokens

@argerus argerus force-pushed the feature/wildcard_matching_doc branch from 5f364b4 to 7f4d009 Compare September 5, 2023 15:08
@argerus argerus force-pushed the feature/wildcard_matching_doc branch from 7f4d009 to 0e4f5af Compare September 5, 2023 15:10
@argerus argerus merged commit 4dfd785 into eclipse:master Sep 5, 2023
2 checks passed
@erikbosch erikbosch deleted the feature/wildcard_matching_doc branch October 31, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants