Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/recursion issue custom repository #548

Merged
merged 4 commits into from
Aug 31, 2024

Conversation

dearrudam
Copy link
Contributor

Changes

Ref: #547

  • Fix recursion calling to avoid stack overflow on the custom repository's query methods with @query annotation with predefined queries

…erflow on the custom repository's query methods with @query annotation with predefined queries

Signed-off-by: Maximillian Arruda <[email protected]>
@dearrudam
Copy link
Contributor Author

@otaviojava , please, could you review it?

@dearrudam dearrudam merged commit 5ac0745 into main Aug 31, 2024
3 checks passed
@dearrudam
Copy link
Contributor Author

dearrudam commented Aug 31, 2024

I merged it because I'm planning to be presenting at Java Day São José do Rio Preto event, speaking about Jakarta Data spec!

@otaviojava otaviojava deleted the feature/recursion-issue-custom-repository branch August 31, 2024 14:36
@otaviojava
Copy link
Member

No problem, Max, it is okay.
With the PR, we can see the history.

The documentation is the key, we don't need to be super burocratic in our process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants