Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate all languages after EMF bump #3303

Merged
merged 14 commits into from
Dec 18, 2024
Merged

Regenerate all languages after EMF bump #3303

merged 14 commits into from
Dec 18, 2024

Conversation

szarnekow
Copy link
Contributor

Added scripts to relengutils that allow to generate multiple languages in one step

Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
Signed-off-by: Sebastian Zarnekow <[email protected]>
@szarnekow szarnekow requested a review from cdietrich December 18, 2024 09:54
@szarnekow szarnekow self-assigned this Dec 18, 2024
@szarnekow
Copy link
Contributor Author

MWE2 files for test languages are still pending.
Yet I'm curious if the new mwe2 files work for you, too @cdietrich @LorenzoBettini - mind the hint

/**
 * Must run with -Dslf4j.provider=org.slf4j.simple.SimpleServiceProvider
 */

Copy link

github-actions bot commented Dec 18, 2024

Test Results

  6 461 files  ±0    6 461 suites  ±0   3h 17m 5s ⏱️ + 1m 2s
 43 239 tests ±0   42 655 ✅ ±0    584 💤 ±0  0 ❌ ±0 
170 250 runs  ±0  167 904 ✅ ±0  2 337 💤 ±0  9 ❌ ±0 

Results for commit 7c53ee3. ± Comparison against base commit a68a47b.

♻️ This comment has been updated with latest results.

@LorenzoBettini
Copy link
Contributor

@szarnekow just a quick note:

Error:  Cannot resolve dependencies of project org.eclipse.xtext:org.eclipse.xtext.relengutil:eclipse-plugin:2.38.0-SNAPSHOT
Error:   with context {osgi.os=macosx, osgi.ws=cocoa, org.eclipse.update.install.features=true, osgi.arch=x86_64, org.eclipse.update.install.sources=true}
Error:    Software being installed: org.eclipse.xtext.relengutil 2.38.0.qualifier
Error:    Missing requirement: org.eclipse.xtext.relengutil 2.38.0.qualifier requires 'osgi.bundle; org.eclipse.xtext.example.arithmetics 2.38.0' but it could not be found:

@LorenzoBettini
Copy link
Contributor

Unfortunately, those examples are NOT Maven projects

@cdietrich
Copy link
Contributor

cdietrich commented Dec 18, 2024

@LorenzoBettini
Copy link
Contributor

https://github.com/eclipse-tycho/tycho/blob/edb91135cc2e04065da956ea193e676035e0b220/tycho-its/projects/surefire.optionalDependencies.ignore/pom.xml#L37

Maybe by adding that only in the relengutil POM...

@szarnekow
Copy link
Contributor Author

Unfortunately, those examples are NOT Maven projects

I knew the current setup will fail the build, yes. I'll try to change the maven config - likely doing what you suggested, @LorenzoBettini

Signed-off-by: Sebastian Zarnekow <[email protected]>
@LorenzoBettini
Copy link
Contributor

@cdietrich @szarnekow I don't know if that's related to this logging nightmare, but if you generate an xtext project with Maven support and run the Maven build, when running mwe2 you get a warning about missing log configuration and there's no logging output, though the run succeeds.

@cdietrich
Copy link
Contributor

cdietrich commented Dec 18, 2024

you mean pure maven or tycho?

[INFO] �[1m--- �[0;32mexec:3.0.0:java�[m �[1m(mwe2Launcher)�[m @ �[36morg.xtext.example.mydsl1�[0;1m ---�[m
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
0    [org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main()] INFO  text.xtext.generator.XtextGenerator  - Initializing Xtext generator
220  [org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main()] INFO  text.xtext.generator.XtextGenerator  - Generating org.xtext.example.mydsl1.MyDsl
260  [org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main()] INFO  nerator.ecore.EMFGeneratorFragment2  - Generating EMF model code
716  [org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main()] INFO  text.xtext.generator.XtextGenerator  - Generating common infrastructure
717  [org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main()] INFO  .emf.mwe2.runtime.workflow.Workflow  - Done.
[INFO] 

@szarnekow
Copy link
Contributor Author

I'll already merge this and take care of the testlanguages in the next step. Objections?

@LorenzoBettini
Copy link
Contributor

I'll already merge this and take care of the testlanguages in the next step. Objections?

Please go right ahead!

@LorenzoBettini
Copy link
Contributor

you mean pure maven or tycho?

[INFO] �[1m--- �[0;32mexec:3.0.0:java�[m �[1m(mwe2Launcher)�[m @ �[36morg.xtext.example.mydsl1�[0;1m ---�[m
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
0    [org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main()] INFO  text.xtext.generator.XtextGenerator  - Initializing Xtext generator
220  [org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main()] INFO  text.xtext.generator.XtextGenerator  - Generating org.xtext.example.mydsl1.MyDsl
260  [org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main()] INFO  nerator.ecore.EMFGeneratorFragment2  - Generating EMF model code
716  [org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main()] INFO  text.xtext.generator.XtextGenerator  - Generating common infrastructure
717  [org.eclipse.emf.mwe2.launch.runtime.Mwe2Launcher.main()] INFO  .emf.mwe2.runtime.workflow.Workflow  - Done.
[INFO] 

Maven Tycho. Exactly the same warning.

@szarnekow szarnekow merged commit 104098e into main Dec 18, 2024
17 checks passed
@szarnekow szarnekow deleted the sz_issue3247 branch December 18, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants