Disable DirtyStateEditorSupportIntegrationTest.testModifyFileInExternEditor() for mac operating system.

[mehmet-karaman]

@LorenzoBettini @szarnekow If you are ok with this decision, we can merge this PR. Its disbaling the test for the mac operating system.

[LorenzoBettini]

You should use junit assumptions for that. Search for assumeTrue or false in our codebase. That way, the test is marked as skipped.

[mehmet-karaman]

I thought only @ignored annotated tests will be skipped.. The test will start but it will exit on mac before doing anything.. All others will execute that until end.

[mehmet-karaman]

Let me wait until the build is finished, thats totally new for me :)

[github-actions]

Test Results

  6 445 files   -  16    6 445 suites   - 16   2h 59m 13s ⏱️ - 8m 56s
 43 216 tests  -  23   42 595 ✅  -  59    581 💤  -  3   40 ❌ + 39 
170 958 runs  +698  167 664 ✅  - 240  2 325 💤  - 11  968 ❌ +949  1 🔥 ±0 

For more details on these failures, see this check.

Results for commit 6459311. ± Comparison against base commit dec4226.

This pull request removes 23 tests.

org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf00100
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf00200
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf00400
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf00800
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf01600
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf03200
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf06400
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf12800
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf25600
org.eclipse.xtend.core.tests.building.XtendIncrementalBuilderPerformanceTest ‑ testPerf51200
…

♻️ This comment has been updated with latest results.

[LorenzoBettini]

I thought only @ignored annotated tests will be skipped.. The test will start but it will exit on mac before doing anything.. All others will execute that until end.

Yes, but as we said, it's better to use assumptions so that the test is correctly marked as skipped.

[LorenzoBettini]

There are tons of failures related to autoedit strategy. It can't be related to this..

[mehmet-karaman]

I've done a rebase,

[memin20]

Build failed again, but I've checked the test results from the log:

DirtyStateEditorSupportIntegrationTest for Windows worked, for Ubuntu it worked also and for mac skipped it skipped one more test which is expected.

[LorenzoBettini]

The build fails due to a change in platform (see the issue in xtext)