Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate TemporaryFolders #3262

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Remove duplicate TemporaryFolders #3262

merged 3 commits into from
Nov 27, 2024

Conversation

LorenzoBettini
Copy link
Contributor

Closes #1072

  • Added TemporaryFolder in .xtext.testing
  • The existing one in .xbase.testing is now deprecated and extends the new one
  • The other copies have been removed and code adapted to use the new one

@LorenzoBettini LorenzoBettini added this to the Release_2.38 milestone Nov 27, 2024
@github-actions GitHub Actions
Copy link

Test Results

  6 460 files  ±0    6 460 suites  ±0   3h 11m 57s ⏱️ -5s
 43 238 tests ±0   42 654 ✅ ±0    584 💤 ±0  0 ❌ ±0 
170 249 runs   - 2  167 904 ✅ ±0  2 336 💤 ±0  9 ❌  - 1 

Results for commit ad2befb. ± Comparison against base commit 4eebe72.

szarnekow
szarnekow approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@szarnekow szarnekow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@LorenzoBettini LorenzoBettini mentioned this pull request Nov 27, 2024
Closed
@LorenzoBettini LorenzoBettini merged commit 053d760 into eclipse-xtext:main Nov 27, 2024
9 checks passed
@LorenzoBettini LorenzoBettini deleted the lb_1072 branch November 27, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szarnekow szarnekow szarnekow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release_2.38
Development

Successfully merging this pull request may close these issues.

Consider getting rid of "TemporaryFolder" classes
2 participants
@LorenzoBettini @szarnekow