some more defaults changed to java 17 #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzoBettini
force-pushed
the
lb_java17
branch
from
0eb62fa to
9b7f85a
Compare
LorenzoBettini
force-pushed
the
cd-lb_java17
branch
from
e03c3a8 to
d6de833
Compare
LorenzoBettini
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
@cdietrich I hope you don't mind: I rebased your branch on top of the rebased branch of mine, in order to make the build green again with the merged default Java 21 PR.
If I understand correctly, this fixes the remaining points in the Java 17 PR, right?
|
yes |
|
OK, so can we now merge the Java 17 PR? |
from my pov yes. @szarnekow wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.