Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump 2.38 and bootstrap xtend-maven-plugin #3248

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

LorenzoBettini
Copy link
Contributor

No description provided.

@cdietrich
Copy link
Contributor

@LorenzoBettini thought we want to bring in your pr first?
or will this be no problem?

@LorenzoBettini
Copy link
Contributor Author

@cdietrich I had already rebased my PR on top of the released main, and solved the conflicts due to the new MWE2.

I guess you're right: bringing my PR in first should save for further conflicts.

So let's postpone this; probably, it will be even easier to simply recreate this PR, since I used the fix version script after all.

Copy link

github-actions bot commented Nov 20, 2024

Test Results

  6 456 files   -  4    6 456 suites   - 4   3h 14m 57s ⏱️ -4s
 43 238 tests ± 0   42 645 ✅  -  9    584 💤 ±0   4 ❌ + 4   5 🔥 + 5 
170 273 runs  +20  167 875 ✅  - 29  2 333 💤  - 3  34 ❌ +21  31 🔥 +31 

For more details on these failures and errors, see this check.

Results for commit a2cc807. ± Comparison against base commit 7ecb428.

♻️ This comment has been updated with latest results.

@LorenzoBettini
Copy link
Contributor Author

@cdietrich so shall we merge the Java 17 PR?

@cdietrich
Copy link
Contributor

@LorenzoBettini are the open points addressed?

@LorenzoBettini
Copy link
Contributor Author

@cdietrich I thought we'd address open points in the future. I seem to recall that there are no blocking open points. CC @szarnekow

@cdietrich
Copy link
Contributor

future = as in a follow up or as "somewhen in 2027"

@LorenzoBettini
Copy link
Contributor Author

That depends on us. It also depends on the importance of the open points.

@cdietrich
Copy link
Contributor

from my pov they should be adressed before the next release

@LorenzoBettini
Copy link
Contributor Author

OK, can you please point me to the points that remain to be addressed? I'll see what I can do.
Or summarize them in the other PR.

@cdietrich
Copy link
Contributor

#3233 (comment)

@LorenzoBettini
Copy link
Contributor Author

@cdietrich the PR has been updated with the Java 17 PR merged.

@LorenzoBettini LorenzoBettini merged commit 7c15225 into main Nov 26, 2024
17 checks passed
@LorenzoBettini LorenzoBettini deleted the lb_bump_2.38 branch November 26, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants